Message-ID: <1503607848.12569.12.camel@perches.com>
Subject: Re: [PATCH] Staging: Android: fix code style in ion_cma_heap.c
From: Joe Perches <joe@perches.com>
To: Abishek V Ashok <abishekvashok@gmail.com>, labbott@redhat.com,
        gregkh@linuxfoundation.org, sumit.semwal@linaro.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Date: Thu, 24 Aug 2017 13:50:48 -0700
In-Reply-To: <20170824154050.11345-1-abishekvashok@gmail.com>
References: <20170824154050.11345-1-abishekvashok@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 686
Lines: 16

On Thu, 2017-08-24 at 21:10 +0530, Abishek V Ashok wrote:
> This is a patch to the ion_cma_heap.c file in
> /drivers/staging/andrioid/ion that fixes a blank line and
> kmalloc size warning found by the checkpatch.pl tool.
[]
> diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c
[]
> @@ -46,7 +45,7 @@ static int ion_cma_allocate(struct ion_heap *heap, struct ion_buffer *buffer,
>  	if (!pages)
>  		return -ENOMEM;
> 
> -	table = kmalloc(sizeof(struct sg_table), GFP_KERNEL);
> +	table = kmalloc(sizeof(struct * table), GFP_KERNEL);

Please make sure you compile the files modified by
your proposed patches before sending the patches.