Date: Thu, 24 Aug 2017 23:01:21 +0200
From: Stefan Lippers-Hollmann <s.l-h@gmx.de>
To: ebiederm@xmission.com (Eric W. Biederman)
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
        Christian Brauner <christian.brauner@canonical.com>,
        Christian Brauner <christian.brauner@ubuntu.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "Serge E. Hallyn" <serge@hallyn.com>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Thorsten Leemhuis <regressions@leemhuis.info>
Subject: Re: [PATCH v3] pty: Repair TIOCGPTPEER
Message-ID: <20170824230121.2221763a@mir>
In-Reply-To: <87a82od8ra.fsf_-_@xmission.com>
References: <20170816171211.4021-1-christian.brauner@ubuntu.com>
        <87ziazqdfr.fsf@xmission.com>
        <CA+55aFwssaZpapQdc2iVVmMt0KxTHYdeo71Xbp4Ex-pYP_MpMw@mail.gmail.com>
        <20170824022436.44adb497@mir>
        <CA+55aFzHa0vL2Yui05r6aSQM0-oHuUAjqi1kxheG_tFQRkUGYw@mail.gmail.com>
        <87378hhi3y.fsf@xmission.com>
        <CA+55aFxhg8=KMZDtF-TrVjb3fPNvSWUveuRy1HHGuWXQ3+YzwQ@mail.gmail.com>
        <CA+55aFw737C9OVC2nQgGcazhi7Ca2K-frzgN2MiD=XqqFAp8YA@mail.gmail.com>
        <CA+55aFwvwtFCH2THn1LirOpMsZ57pnNi61nXQfQ6NBgakdXpTQ@mail.gmail.com>
        <87wp5tfynr.fsf@xmission.com>
        <20170824062432.1e05e6f8@mir>
        <874lsxezal.fsf@xmission.com>
        <CA+55aFz62HAC=v0=wVDPwdSPRXAnPGoAec1o==22AqrQchUzUQ@mail.gmail.com>
        <CA+55aFyO-70cz3ByOmD3zWByy+1x20VK5UajLa1p_-Gi8Y1nQg@mail.gmail.com>
        <CA+55aFxiDZAcFvngiNGUT=o78i1SWZ-tSHDYV4TKebiixiD6Pg@mail.gmail.com>
        <87y3q8ermg.fsf@xmission.com>
        <CA+55aFy5qo3Gsfi9PY0QMtK=jAnKYohY2U3ohQefmqSMVx156g@mail.gmail.com>
        <87a82od8ra.fsf_-_@xmission.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 boundary="Sig_/206pV2g31gk8Tc0bEtS96ZZ"; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1761
Lines: 48

--Sig_/206pV2g31gk8Tc0bEtS96ZZ
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi

On 2017-08-24, Eric W. Biederman wrote:
> The implementation of TIOCGPTPEER has two issues.
>=20
> When /dev/ptmx (as opposed to /dev/pts/ptmx) is opened the wrong
> vfsmount is passed to dentry_open.  Which results in the kernel displaying
> the wrong pathname for the peer.

[...]

> v2: Lots of fixes to make the code actually work
> v3: Suggestions by Linus
>     - Removed the unnecessary initialization of filp in ptm_open_peer
>     - Simplified devpts_ptmx_path as gotos are no longer required

This version of the patch is working for me as well in all my test
(including pbuilder) so far, thanks a lot.

Regards
	Stefan Lippers-Hollmann

--Sig_/206pV2g31gk8Tc0bEtS96ZZ
Content-Type: application/pgp-signature
Content-Description: Digitale Signatur von OpenPGP

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEMQMcJCzZm4GSqVV4v+AtZbHRQu0FAlmfPqEACgkQv+AtZbHR
Qu3WRxAAo0PI8U3MNbEJTHuRg3LEkS8ae/wn8akExN2Lc8YLmdrhzJRMu8RD7J6C
0z/K46KGTagAkrZm8S41Y7mPz7p+fFbWfHhOpXqgm0dY0lbC+F6t0IX0C+7HsHPN
ApeLwV77KWIa4a6D22ff6IfnyJ+UpurCsqLmQ6eaiM3RwSrmOcEIW/YTqVTLnUGJ
NcBj+2ASg+cWsVXkwWYX4JfwwsQcGxuc1TsY3AnARC2ht0H4Odqq66CX7vl49Oh4
Hodx1Po2DaHP5CRPoDQWBOS8zQo3syaAMQFPDHIRUPESMmPomuAbjNEkFAGW9u5C
fhVdH8A49S5QEUfIEygfAlsvABrZBDIZwxDokCxPPkoO5I0SilnQolYVvpTdt00h
LSKMfy6NsQoyR3PsfMuLCN/NnlKcSfXpvIKpxGQjCDCChrtzfybw24PcdA8DXJG1
F8ZEvskR/BpAjWDec76JpR2piujYz7vGVjbhQ2eoK+JD5ptKcUea/K1bNb++N+MY
LqIe2z9AWCN8P/h4Qn71+LbFXwjj1jYl8RB5+/NiTe+wxYGMIHuftT+CE1xhNEQ0
2enbyEmpRja9TtlZOl564Xc4RJI0TQRPnjBB02ZhMDlpC51fw7AVXrDQPNyhBMSO
ayaKBqqKzeSWR0tpyTk9dhVW1fl7X0SkmnkelQTKPCAybLLkPm4=
=T21Y
-----END PGP SIGNATURE-----

--Sig_/206pV2g31gk8Tc0bEtS96ZZ--