Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753722AbdHXV7D (ORCPT ); Thu, 24 Aug 2017 17:59:03 -0400 Received: from fllnx209.ext.ti.com ([198.47.19.16]:10409 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753411AbdHXV7B (ORCPT ); Thu, 24 Aug 2017 17:59:01 -0400 Subject: Re: [PATCH 071/102] remoteproc/keystone: explicitly request exclusive reset control From: Suman Anna To: Philipp Zabel , , Bjorn Andersson CC: Ohad Ben-Cohen , References: <20170719152646.25903-1-p.zabel@pengutronix.de> <20170719152646.25903-72-p.zabel@pengutronix.de> <0756b169-6f70-5919-020b-367df898dc3f@ti.com> Message-ID: <45e1af7f-b931-ffd4-4447-b45f9038a089@ti.com> Date: Thu, 24 Aug 2017 16:58:11 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <0756b169-6f70-5919-020b-367df898dc3f@ti.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [128.247.58.153] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1659 Lines: 46 Hi Bjorn, On 07/19/2017 11:59 AM, Suman Anna wrote: > On 07/19/2017 10:26 AM, Philipp Zabel wrote: >> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting >> reset lines") started to transition the reset control request API calls >> to explicitly state whether the driver needs exclusive or shared reset >> control behavior. Convert all drivers requesting exclusive resets to the >> explicit API call so the temporary transition helpers can be removed. >> >> No functional changes. >> >> Cc: Ohad Ben-Cohen >> Cc: Bjorn Andersson >> Cc: linux-remoteproc@vger.kernel.org >> Signed-off-by: Philipp Zabel > > Acked-by: Suman Anna Can you pick this one and the other 2 related remoteproc patches? Believe the subsystem maintainers have been picking these up, I see some of the other related patches in linux-next but not these. regards Suman > >> --- >> drivers/remoteproc/keystone_remoteproc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/remoteproc/keystone_remoteproc.c b/drivers/remoteproc/keystone_remoteproc.c >> index 5f776bfd674a0..920fef072b364 100644 >> --- a/drivers/remoteproc/keystone_remoteproc.c >> +++ b/drivers/remoteproc/keystone_remoteproc.c >> @@ -410,7 +410,7 @@ static int keystone_rproc_probe(struct platform_device *pdev) >> if (ret) >> goto free_rproc; >> >> - ksproc->reset = devm_reset_control_get(dev, NULL); >> + ksproc->reset = devm_reset_control_get_exclusive(dev, NULL); >> if (IS_ERR(ksproc->reset)) { >> ret = PTR_ERR(ksproc->reset); >> goto free_rproc; >> >