Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753962AbdHXWlL (ORCPT ); Thu, 24 Aug 2017 18:41:11 -0400 Received: from mail-pg0-f53.google.com ([74.125.83.53]:33948 "EHLO mail-pg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753566AbdHXWlK (ORCPT ); Thu, 24 Aug 2017 18:41:10 -0400 Date: Thu, 24 Aug 2017 15:41:02 -0700 From: Stephen Hemminger To: kys@exchange.microsoft.com, Haiyang Zhang Cc: kys@microsoft.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, vkuznets@redhat.com, jasowang@redhat.com, leann.ogasawara@canonical.com, marcelo.cerri@canonical.com, sthemmin@microsoft.com Subject: Re: [PATCH 1/1] Drivers: hv: vmbus: Fix rescind handling issues Message-ID: <20170824154102.62a02190@xeon-e3> In-Reply-To: <1502471039-5281-1-git-send-email-kys@exchange.microsoft.com> References: <1502471039-5281-1-git-send-email-kys@exchange.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1170 Lines: 29 On Fri, 11 Aug 2017 10:03:59 -0700 kys@exchange.microsoft.com wrote: > From: K. Y. Srinivasan > > This patch handles the following issues that were observed when we are > handling racing channel offer message and rescind message for the same > offer: > > 1. Since the host does not respond to messages on a rescinded channel, > in the current code, we could be indefinitely blocked on the vmbus_open() call. > > 2. When a rescinded channel is being closed, if there is a pending interrupt on the > channel, we could end up freeing the channel that the interrupt handler would run on. > > Signed-off-by: K. Y. Srinivasan > Reviewed-by: Dexuan Cui > Tested-by: Dexuan Cui This patch breaks re-initialization of the network device on MTU changes. Doing: # ip li set dev eth1 mtu 9000 will hang in rndis_filter_add waiting for subchannel notification. This is likely because when the vmbus device is reopened the sub channels are not correctly created. Not sure what is wrong with the patch, but my suspicion is that the close/rescind events are no longer being sent to the host.