Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754099AbdHXXIr (ORCPT ); Thu, 24 Aug 2017 19:08:47 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:34654 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753998AbdHXXIp (ORCPT ); Thu, 24 Aug 2017 19:08:45 -0400 Date: Thu, 24 Aug 2017 16:08:42 -0700 From: Dmitry Torokhov To: Arvind Yadav Cc: linux@armlinux.org.uk, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [PATCH] Input: ambakmi: constify amba_id Message-ID: <20170824230842.GA22810@dtor-ws> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 911 Lines: 31 On Wed, Aug 23, 2017 at 09:49:11PM +0530, Arvind Yadav wrote: > amba_id are not supposed to change at runtime. All functions > working with const amba_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav Applied, thank you. > --- > drivers/input/serio/ambakmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/serio/ambakmi.c b/drivers/input/serio/ambakmi.c > index c6606ca..ff3875c 100644 > --- a/drivers/input/serio/ambakmi.c > +++ b/drivers/input/serio/ambakmi.c > @@ -187,7 +187,7 @@ static int __maybe_unused amba_kmi_resume(struct device *dev) > > static SIMPLE_DEV_PM_OPS(amba_kmi_dev_pm_ops, NULL, amba_kmi_resume); > > -static struct amba_id amba_kmi_idtable[] = { > +static const struct amba_id amba_kmi_idtable[] = { > { > .id = 0x00041050, > .mask = 0x000fffff, > -- > 2.7.4 > -- Dmitry