Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754444AbdHYAnx (ORCPT ); Thu, 24 Aug 2017 20:43:53 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:33682 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753803AbdHYAnv (ORCPT ); Thu, 24 Aug 2017 20:43:51 -0400 Subject: Re: [PATCH 0/3] KVM, pkeys: fix handling of PKRU across migration To: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: junkang.fjk@alibaba-inc.com, quan.xu0@gmail.com References: <1503569573-55057-1-git-send-email-pbonzini@redhat.com> From: Yang Zhang Message-ID: <8d8ce265-2417-122b-9b5a-7a5dd0d3f0fd@gmail.com> Date: Fri, 25 Aug 2017 08:43:47 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1503569573-55057-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1386 Lines: 47 On 2017/8/24 18:12, Paolo Bonzini wrote: > The host pkru is restored right after vcpu exit (commit 1be0e61), so > KVM_GET_XSAVE will return the host PKRU value instead. In general, > the PKRU value in vcpu->arch.guest_fpu.state cannot be trusted. > > Series as follows: > > 1) fix independent bug which would cause an oops > > 2) remove an unnecessary abstraction > > 3) fix the bug > > Please test the patches, as I don't have the affected hardware. Note > that I need the results before tomorrow in order to send these patches > to Linus before going on vacation. hi Quan Can you help to test Paolo's patch? > > Thanks, > > Paolo > > > Paolo Bonzini (3): > KVM: x86: block guest protection keys unless the host has them enabled > KVM: x86: simplify handling of PKRU > KVM, pkeys: do not use PKRU value in vcpu->arch.guest_fpu.state > > arch/x86/include/asm/fpu/internal.h | 6 +++--- > arch/x86/include/asm/kvm_host.h | 1 + > arch/x86/kvm/cpuid.c | 2 +- > arch/x86/kvm/kvm_cache_regs.h | 5 ----- > arch/x86/kvm/mmu.h | 2 +- > arch/x86/kvm/svm.c | 7 ------- > arch/x86/kvm/vmx.c | 25 ++++++++----------------- > arch/x86/kvm/x86.c | 17 ++++++++++++++--- > 8 files changed, 28 insertions(+), 37 deletions(-) > -- Yang Alibaba Cloud Computing