Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754253AbdHYAyt (ORCPT ); Thu, 24 Aug 2017 20:54:49 -0400 Received: from mail-qk0-f173.google.com ([209.85.220.173]:38476 "EHLO mail-qk0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754021AbdHYAyr (ORCPT ); Thu, 24 Aug 2017 20:54:47 -0400 Subject: Re: [PATCH v3 0/2] SoC driver for Broadcom STB DPFE To: Markus Mayer , Rob Herring , Mark Rutland , Gregory Fong Cc: Markus Mayer , Broadcom Kernel List , Device Tree List , ARM Kernel List , Linux Kernel Mailing List References: <20170824233626.1343-1-code@mmayer.net> From: Florian Fainelli Message-ID: Date: Thu, 24 Aug 2017 17:54:42 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170824233626.1343-1-code@mmayer.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1655 Lines: 41 On 08/24/2017 04:36 PM, Markus Mayer wrote: > From: Markus Mayer > > This series introduces a driver to interact with the Broadcom STB DDR > PHY Front End (DPFE), specifically to communicate with the DCPU that is > part of the DDR PHY and which is running its own firmware. > > The DCPU provides information such as DRAM refresh rate, which can be > used as indirect indicator for the DRAM temperature (the higher the > refresh rate, the hotter the RAM). > > The series was previously submitted as HWMON driver[1]. It has been > removed from that subsystem, because it doesn't provide any standard > HWMON data due to hardware design properties, and is now implemented as > SoC driver. > > Changes since v2: > - moved driver from drivers/soc/bcm/brcmstb to drivers/memory > - renamed the driver from dpfe.c to brcmstb_dpfe.c > - added le32_to_cpu() in a few places (where be32_to_cpu() calls > already existed) > - added a little blurb what the le32_to_cpu()/be32_to_cpu() business > is all about > > Changes since v1: > - binding simplified to use one node with three memory regions > instead of three nodes with one region > - no longer part of the HWMON subsystem > - better error handling and error reporting to userland > - uses [readl|writel]_relaxed() directly, since there is no need for > wrappers doing endian conversion > - re-download firmware upon "resume" > - minor changes to improve clarity > > [1] https://lkml.org/lkml/2017/4/18/640 Applied, thanks Markus! Will get that resubmitted in a short while: https://github.com/Broadcom/stblinux/commits/drivers/next -- Florian