Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754389AbdHYB0j convert rfc822-to-8bit (ORCPT ); Thu, 24 Aug 2017 21:26:39 -0400 Received: from ozlabs.org ([103.22.144.67]:43283 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754066AbdHYB0g (ORCPT ); Thu, 24 Aug 2017 21:26:36 -0400 From: Michael Ellerman To: Corentin Labbe Cc: benh@kernel.crashing.org, paulus@samba.org, anju@linux.vnet.ibm.com, maddy@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] powerpc: powernv: Fix build error on const discarding In-Reply-To: <20170818125816.GA15998@Red> References: <20170816123444.5202-1-clabbe.montjoie@gmail.com> <87fucqbblw.fsf@concordia.ellerman.id.au> <20170818125816.GA15998@Red> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Fri, 25 Aug 2017 11:26:32 +1000 Message-ID: <87h8wwv3nb.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 971 Lines: 37 Corentin Labbe writes: > On Thu, Aug 17, 2017 at 10:52:11PM +1000, Michael Ellerman wrote: >> Corentin Labbe writes: >> >> > When building a random powerpc kernel I hit this build error: >> > CC arch/powerpc/platforms/powernv/opal-imc.o >> > arch/powerpc/platforms/powernv/opal-imc.c: In function « disable_nest_pmu_counters »: >> > arch/powerpc/platforms/powernv/opal-imc.c:130:13: error : assignment discards « const » qualifier from pointer target type [-Werror=discarded-qualifiers] >> > l_cpumask = cpumask_of_node(nid); >> > ^ >> > This patch simply add const to l_cpumask to fix this issue. >> >> Thanks. I'm not sure why we haven't seen that. >> >> Do you mind attaching your .config ? >> >> cheers > > Yes Thanks. So the key is: > CONFIG_PPC_POWERNV=y ... > # CONFIG_NUMA is not set Which none of our configs have. I'll add a test build of that. Thanks. cheers