Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754311AbdHYBdx (ORCPT ); Thu, 24 Aug 2017 21:33:53 -0400 Received: from icp-osb-irony-out7.external.iinet.net.au ([203.59.1.107]:22785 "EHLO icp-osb-irony-out7.external.iinet.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754220AbdHYBdw (ORCPT ); Thu, 24 Aug 2017 21:33:52 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2DpAACpe59Z/zXSMGcNUBkBAQEBAQEBAQEBAQcBAQEBAYVTg3eadQaBCCKYN4VHAoUUFQECAQEBAQEBAYYsAQEBAyNWEAsNCwICJgICVwYBDAYCAQGKIKxZa4InIos/AQEBAQEBAQEBAQEBAQEBASKBDYIdgweCVQuCcYgGgmEFiX6HHY89AaAqhn+WMDWBLDIhCCkIhWAcgXlkihYBAQE X-IPAS-Result: A2DpAACpe59Z/zXSMGcNUBkBAQEBAQEBAQEBAQcBAQEBAYVTg3eadQaBCCKYN4VHAoUUFQECAQEBAQEBAYYsAQEBAyNWEAsNCwICJgICVwYBDAYCAQGKIKxZa4InIos/AQEBAQEBAQEBAQEBAQEBASKBDYIdgweCVQuCcYgGgmEFiX6HHY89AaAqhn+WMDWBLDIhCCkIhWAcgXlkihYBAQE X-IronPort-AV: E=Sophos;i="5.41,423,1498492800"; d="scan'208";a="885238" Subject: Re: [PATCH] m68knommu: remove dead code To: Alexandre Belloni , Geert Uytterhoeven Cc: linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170824143407.21273-1-alexandre.belloni@free-electrons.com> From: Greg Ungerer Message-ID: Date: Fri, 25 Aug 2017 11:24:47 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170824143407.21273-1-alexandre.belloni@free-electrons.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1693 Lines: 66 Hi Alexandre, On 25/08/17 00:34, Alexandre Belloni wrote: > As CONFIG_RTC_DRV_M5441x doesn't exist because the driver never made it > upstream, there is no device to register. Remove code that is never > compiled and init_BSP() as it doesn't do anything. > > Signed-off-by: Alexandre Belloni Looks good, thanks. I have applied to m68knommu git tree, for-next branch. Regards Greg > --- > arch/m68k/coldfire/m5441x.c | 37 ------------------------------------- > 1 file changed, 37 deletions(-) > > diff --git a/arch/m68k/coldfire/m5441x.c b/arch/m68k/coldfire/m5441x.c > index dc589b039b62..04fd7fde9fb3 100644 > --- a/arch/m68k/coldfire/m5441x.c > +++ b/arch/m68k/coldfire/m5441x.c > @@ -222,40 +222,3 @@ void __init config_BSP(char *commandp, int size) > m5441x_uarts_init(); > m5441x_fec_init(); > } > - > - > -#if IS_ENABLED(CONFIG_RTC_DRV_M5441x) > -static struct resource m5441x_rtc_resources[] = { > - { > - .start = MCFRTC_BASE, > - .end = MCFRTC_BASE + MCFRTC_SIZE - 1, > - .flags = IORESOURCE_MEM, > - }, > - { > - .start = MCF_IRQ_RTC, > - .end = MCF_IRQ_RTC, > - .flags = IORESOURCE_IRQ, > - }, > -}; > - > -static struct platform_device m5441x_rtc = { > - .name = "mcfrtc", > - .id = 0, > - .resource = m5441x_rtc_resources, > - .num_resources = ARRAY_SIZE(m5441x_rtc_resources), > -}; > -#endif > - > -static struct platform_device *m5441x_devices[] __initdata = { > -#if IS_ENABLED(CONFIG_RTC_DRV_M5441x) > - &m5441x_rtc, > -#endif > -}; > - > -static int __init init_BSP(void) > -{ > - platform_add_devices(m5441x_devices, ARRAY_SIZE(m5441x_devices)); > - return 0; > -} > - > -arch_initcall(init_BSP); >