Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751508AbdHYEjU (ORCPT ); Fri, 25 Aug 2017 00:39:20 -0400 Received: from LGEAMRELO11.lge.com ([156.147.23.51]:60576 "EHLO lgeamrelo11.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751377AbdHYEjS (ORCPT ); Fri, 25 Aug 2017 00:39:18 -0400 X-Original-SENDERIP: 156.147.1.126 X-Original-MAILFROM: byungchul.park@lge.com X-Original-SENDERIP: 10.177.222.33 X-Original-MAILFROM: byungchul.park@lge.com Date: Fri, 25 Aug 2017 13:39:14 +0900 From: Byungchul Park To: Peter Zijlstra Cc: mingo@kernel.org, tj@kernel.org, boqun.feng@gmail.com, david@fromorbit.com, johannes@sipsolutions.net, oleg@redhat.com, linux-kernel@vger.kernel.org, kernel-team@lge.com Subject: Re: [PATCH 4/4] lockdep: Fix workqueue crossrelease annotation Message-ID: <20170825043914.GE3858@X58A-UD3R> References: <20170823115843.662056844@infradead.org> <20170823121432.990701317@infradead.org> <20170824021840.GC6772@X58A-UD3R> <20170824140240.t4imrpvussebfimm@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170824140240.t4imrpvussebfimm@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 516 Lines: 13 On Thu, Aug 24, 2017 at 04:02:40PM +0200, Peter Zijlstra wrote: > > > + if (c == XHLOCK_PROC) { I found this now. Are you trying to invalidate it w/o checking force? No, we _should not_ do this. It's worse than work-around code. No reason to do this here. Please communicate with me more or understand how this code works before applying it. > > > + /* verified the former, ensure the latter */ > > > + WARN_ON_ONCE(!force && cur->lockdep_depth); > > > + invalidate_xhlock(&xhlock(cur->xhlock_idx)); > > > }