Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754202AbdHYF1C (ORCPT ); Fri, 25 Aug 2017 01:27:02 -0400 Received: from mail-pg0-f48.google.com ([74.125.83.48]:34804 "EHLO mail-pg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751699AbdHYF1B (ORCPT ); Fri, 25 Aug 2017 01:27:01 -0400 Date: Fri, 25 Aug 2017 14:27:17 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Andrew Morton , linux-kernel@vger.kernel.org, Nick Terrell , Sergey Senozhatsky Subject: Re: [PATCH] zram: add zstd to the supported algorithms list Message-ID: <20170825052717.GD5876@jagdpanzerIV.localdomain> References: <20170824014936.4738-1-sergey.senozhatsky@gmail.com> <20170824043038.GA13922@bgram> <20170824140440.GA5535@tigerII.localdomain> <20170825045036.GA26819@blaptop> <20170825050644.GB5876@jagdpanzerIV.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170825050644.GB5876@jagdpanzerIV.localdomain> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1150 Lines: 28 On (08/25/17 14:06), Sergey Senozhatsky wrote: > > Off-topic: > > > > In all ways, zstd beats deflate. Nick, Right? > > > > With zstd, I doubt we should show "deflate" to user. Many options just > > make user confused. > > The inflate have been there for representing high comp ratio but slower > > speed. However, zstd is better unconditionally compared to deflate > > so how about replacing deflate with zstd? > > > > Sergey, what do you think about it? > > hmmm... frankly, I don't think it would confuse anyone. the code is > there - compiled - anyway, and the module is visible in /proc/crypto > etc. if we will make it unavailable in zram then this can be confusing, > probably... if anyone ever pays any attention at all. my guess is that > people look what's in /sys/block/zram0/comp_algorithm just once, then > they set up a create-zram script/systemd unit file/etc. and forget > about it. > > cryto API is just a wrapper and it calls lib/comp_foo to do the actual > work, and that lib/comp_foo *may be* can be implemented as a H/W (not > S/W) compressing backend. well, who knows. but I can remove deflate, if you insist. sure. -ss