Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754258AbdHYFsD (ORCPT ); Fri, 25 Aug 2017 01:48:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39068 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751686AbdHYFsC (ORCPT ); Fri, 25 Aug 2017 01:48:02 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8528E5D68C Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=dyoung@redhat.com Date: Fri, 25 Aug 2017 13:47:49 +0800 From: Dave Young To: AKASHI Takahiro Cc: catalin.marinas@arm.com, will.deacon@arm.com, bauerman@linux.vnet.ibm.com, dhowells@redhat.com, vgoyal@redhat.com, herbert@gondor.apana.org.au, davem@davemloft.net, akpm@linux-foundation.org, mpe@ellerman.id.au, bhe@redhat.com, arnd@arndb.de, ard.biesheuvel@linaro.org, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/14] kexec_file: factor out crashdump elf header function from x86 Message-ID: <20170825054749.GA8604@dhcp-128-65.nay.redhat.com> References: <20170824081811.19299-1-takahiro.akashi@linaro.org> <20170824081811.19299-6-takahiro.akashi@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170824081811.19299-6-takahiro.akashi@linaro.org> User-Agent: Mutt/1.8.3 (2017-05-23) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 25 Aug 2017 05:48:02 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 605 Lines: 17 On 08/24/17 at 05:18pm, AKASHI Takahiro wrote: > prepare_elf_headers() can also be useful for other architectures, > including arm64. So let it factored out. > > Signed-off-by: AKASHI Takahiro > Cc: Dave Young > Cc: Vivek Goyal > Cc: Baoquan He > --- > arch/x86/kernel/crash.c | 324 ---------------------------------------------- > include/linux/kexec.h | 19 +++ > kernel/crash_core.c | 333 ++++++++++++++++++++++++++++++++++++++++++++++++ It looks better to add these to kexec_file.c instead. Thanks Dave