Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754698AbdHYHsI (ORCPT ); Fri, 25 Aug 2017 03:48:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:52946 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754521AbdHYHsG (ORCPT ); Fri, 25 Aug 2017 03:48:06 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8684121A1A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=shawnguo@kernel.org Date: Fri, 25 Aug 2017 15:47:46 +0800 From: Shawn Guo To: Stephen Boyd Cc: Kiran Gunda , gregkh@linuxfoundation.org, Rob Herring , Mark Rutland , Abhijeet Dharmapurikar , David Collins , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-msm-owner@vger.kernel.org Subject: Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally Message-ID: <20170825074324.GF3685@dragon> References: <1503070110-15018-1-git-send-email-kgunda@codeaurora.org> <20170822085541.GB3685@dragon> <20170822203132.GC21656@codeaurora.org> <20170824121818.GE3685@dragon> <20170824183701.GN21656@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170824183701.GN21656@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1867 Lines: 47 On Thu, Aug 24, 2017 at 11:37:01AM -0700, Stephen Boyd wrote: > On 08/24, Shawn Guo wrote: > > On Tue, Aug 22, 2017 at 01:31:32PM -0700, Stephen Boyd wrote: > > > Also, I see that on v4.13-rc series the read/write checks are > > > causing the led driver to fail in a different way: > > > > > > spmi spmi-0: error: impermissible write to peripheral sid:0 addr:0xc040 > > > qcom-spmi-gpio 200f000.spmi:pm8916@0:gpios@c000: write 0x40 failed > > > leds-gpio soc:leds: Error applying setting, reverse things back > > > spmi spmi-0: error: impermissible write to peripheral sid:0 addr:0xc041 > > > qcom-spmi-gpio 200f000.spmi:pm8916@0:gpios@c000: write 0x41 failed > > > leds-gpio: probe of soc:leds failed with error -1 > > > > > > Are you seeing similar behavior? > > > > Yes. I forgot to mention that, and leds-gpio failure is gone after > > applying Kiran's patch below. > > > > spmi: pmic-arb: remove the read/write access checks > > > > Sure. Removing the checks will silence the warnings, but it still > means that we're attempting to configure GPIOs that we shouldn't > be configuring. The driver is attempting to configure the GPIOs that device tree tells to. led@3 { label = "apq8016-sbc:green:user3"; gpios = <&pm8916_gpios 1 GPIO_ACTIVE_HIGH>; linux,default-trigger = "mmc1"; default-state = "off"; }; Are you saying, in case of user3 led above, device tree shouldn't use GPIO <&pm8916_gpios 1> there at all? > Is there some sort of default configuration that > gets applied to all pins by default? I do not quite understand what you are asking and how that is related to the thing we discuss here. But my understanding is that spmi_arb read/write access is used not only by pinctrl API to set up pinmux for GPIO function, but also by GPIO API to actually drive the GPIO. Shawn