Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754772AbdHYH7A (ORCPT ); Fri, 25 Aug 2017 03:59:00 -0400 Received: from mail-io0-f180.google.com ([209.85.223.180]:37919 "EHLO mail-io0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754733AbdHYH66 (ORCPT ); Fri, 25 Aug 2017 03:58:58 -0400 X-Google-Smtp-Source: ADKCNb56KibcI6MeShgE1ZTGt7mHiJiMbSUymb2I5hJSTBa6WDpxmbB8MKuYqAgLgOKUBXg3tBqpoo7Uy2UiTMzVHw4= MIME-Version: 1.0 From: Hsin-yu Chao Date: Fri, 25 Aug 2017 15:58:56 +0800 X-Google-Sender-Auth: 6dz_D1vpaKV9mCyRmvTSB1IsuWk Message-ID: Subject: Re: linux-next: build failure after merge of the sound-asoc tree To: Stephen Rothwell Cc: Mark Brown , Liam Girdwood , Linux-Next Mailing List , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 825 Lines: 28 Sorry for the trouble. Looks like these rt5514_spi_* functions should be guarded by #if IS_ENABLED(CONFIG_SND_SOC_RT5514_SPI) I'll resend the patch to address this. Thanks, Hsin-yu On Fri, Aug 25, 2017 at 3:41 PM, Stephen Rothwell wrote: > Hi all, > > After merging the sound-asoc tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > sound/soc/codecs/rt5514.c: In function 'rt5514_dsp_voice_wake_up_put': > sound/soc/codecs/rt5514.c:343:11: error: implicit declaration of function 'rt5514_spi_burst_write' [-Werror=implicit-function-declaration] > ret = rt5514_spi_burst_write(0x4ff80000, > ^ > > Caused by commit > > d18420b0a0b8 ("ASoC: rt5514: expose Hotword Model control") > > I have reverted that commit for today. > > -- > Cheers, > Stephen Rothwell