Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754791AbdHYIAB (ORCPT ); Fri, 25 Aug 2017 04:00:01 -0400 Received: from smtp-sh.infomaniak.ch ([128.65.195.4]:49693 "EHLO smtp-sh.infomaniak.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754709AbdHYH76 (ORCPT ); Fri, 25 Aug 2017 03:59:58 -0400 Subject: Re: [PATCH net-next v7 01/10] selftest: Enhance kselftest_harness.h with a step mechanism To: Alexei Starovoitov , Shuah Khan References: <20170821000933.13024-1-mic@digikod.net> <20170821000933.13024-2-mic@digikod.net> <20170824023105.gt6lyn2snhczryik@ast-mbp> Cc: linux-kernel@vger.kernel.org, Alexei Starovoitov , Andy Lutomirski , Arnaldo Carvalho de Melo , Casey Schaufler , Daniel Borkmann , David Drysdale , "David S . Miller" , "Eric W . Biederman" , James Morris , Jann Horn , Jonathan Corbet , Matthew Garrett , Michael Kerrisk , Kees Cook , Paul Moore , Sargun Dhillon , "Serge E . Hallyn" , Tejun Heo , Thomas Graf , Will Drewry , kernel-hardening@lists.openwall.com, linux-api@vger.kernel.org, linux-security-module@vger.kernel.org, netdev@vger.kernel.org From: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= Message-ID: <0e15da13-fad0-ba01-053c-1b4853e2bd6f@digikod.net> Date: Fri, 25 Aug 2017 09:58:33 +0200 User-Agent: MIME-Version: 1.0 In-Reply-To: <20170824023105.gt6lyn2snhczryik@ast-mbp> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="j9s9wGVNtit22hNfKuJ4gG5AXcFDrKD2s" X-Antivirus: Dr.Web (R) for Unix mail servers drweb plugin ver.6.0.2.8 X-Antivirus-Code: 0x100000 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4056 Lines: 99 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --j9s9wGVNtit22hNfKuJ4gG5AXcFDrKD2s Content-Type: multipart/mixed; boundary="UeCjjMRncgOANfvqB1uxGuu9d3I3RnmWI"; protected-headers="v1" From: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= To: Alexei Starovoitov , Shuah Khan Cc: linux-kernel@vger.kernel.org, Alexei Starovoitov , Andy Lutomirski , Arnaldo Carvalho de Melo , Casey Schaufler , Daniel Borkmann , David Drysdale , "David S . Miller" , "Eric W . Biederman" , James Morris , Jann Horn , Jonathan Corbet , Matthew Garrett , Michael Kerrisk , Kees Cook , Paul Moore , Sargun Dhillon , "Serge E . Hallyn" , Tejun Heo , Thomas Graf , Will Drewry , kernel-hardening@lists.openwall.com, linux-api@vger.kernel.org, linux-security-module@vger.kernel.org, netdev@vger.kernel.org Message-ID: <0e15da13-fad0-ba01-053c-1b4853e2bd6f@digikod.net> Subject: Re: [PATCH net-next v7 01/10] selftest: Enhance kselftest_harness.h with a step mechanism References: <20170821000933.13024-1-mic@digikod.net> <20170821000933.13024-2-mic@digikod.net> <20170824023105.gt6lyn2snhczryik@ast-mbp> In-Reply-To: <20170824023105.gt6lyn2snhczryik@ast-mbp> --UeCjjMRncgOANfvqB1uxGuu9d3I3RnmWI Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 24/08/2017 04:31, Alexei Starovoitov wrote: > On Mon, Aug 21, 2017 at 02:09:24AM +0200, Micka=EBl Sala=FCn wrote: >> This step mechanism may be useful to return an information about the >> error without being able to write to TH_LOG_STREAM. >> >> Set _metadata->no_print to true to print this counter. >> >> Signed-off-by: Micka=EBl Sala=FCn >> Cc: Andy Lutomirski >> Cc: Arnaldo Carvalho de Melo >> Cc: Kees Cook >> Cc: Shuah Khan >> Cc: Will Drewry >> Link: https://lkml.kernel.org/r/CAGXu5j+D-FP8Kt9unNOqKrQJP4DYTpmgkJxWy= kZyrYiVPz3Y3Q@mail.gmail.com >> --- >> >> This patch is intended to the kselftest tree: >> https://lkml.kernel.org/r/20170806232337.4191-1-mic@digikod.net >> >> Changes since v6: >> * add the step counter in assert/expect macros and use _metadata to >> enable the counter (suggested by Kees Cook) >> --- >> tools/testing/selftests/kselftest_harness.h | 31 ++++++++++++++++++= ++++----- >> tools/testing/selftests/seccomp/seccomp_bpf.c | 2 +- >> 2 files changed, 27 insertions(+), 6 deletions(-) >=20 > is there a dependency on this in patches 2+ ? > if not, I would send this patch to selftests right away. >=20 >=20 The Landlock tests [patch 9/10] rely on it for now. I sent it three weeks ago: https://lkml.kernel.org/r/20170806232337.4191-1-mic@digikod.net Anyway, until this patch is merged in the kselftest tree and then available to net-next, I'll have to keep it here. --UeCjjMRncgOANfvqB1uxGuu9d3I3RnmWI-- --j9s9wGVNtit22hNfKuJ4gG5AXcFDrKD2s Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEUysCyY8er9Axt7hqIt7+33O9apUFAlmf2KkACgkQIt7+33O9 apXVFggAqku2EMT7+1wnMtNPleU3+pn6XVupJE8G2oG1ojSl69u5CtNK8G+Lp8Ge aYpbQKXzhqjSVFnuava7HWIH6jmisTzKbkK19lgwMn6nWEY9qgVOdeGyG6HZD29c zPsvNKfugvOxruC7MrbXm/iz+Jj+vhOodBvFVSwFh1GI1ACwUbFV/SSgi41xYv05 Lrx4kpSmGL2+T6pnz7dICg2icbPZNQasEKwdWKmcd9ZjVueqdK1FmFPxGBJh71BW KcGAkcMbEIdg3edPMbUjLbZ0bCZPmlbhqfJfFRtlAXmuMbF/MMMgvuP+tlULFax5 +xL4ORtgzifGonD/WKfWbrZ7fT0izQ== =+G2A -----END PGP SIGNATURE----- --j9s9wGVNtit22hNfKuJ4gG5AXcFDrKD2s--