Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755208AbdHYJX3 (ORCPT ); Fri, 25 Aug 2017 05:23:29 -0400 Received: from gloria.sntech.de ([95.129.55.99]:60716 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754880AbdHYJX1 (ORCPT ); Fri, 25 Aug 2017 05:23:27 -0400 From: Heiko Stuebner To: David Wu Cc: linus.walleij@linaro.org, huangtao@rock-chips.com, andy.yan@rock-chips.com, linux-rockchip@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] pinctrl: rockchip: Add rv1108 recalculated iomux support Date: Fri, 25 Aug 2017 11:23:17 +0200 Message-ID: <23515351.KtMKrjq6Hm@phil> User-Agent: KMail/5.2.3 (Linux/4.11.0-1-amd64; KDE/5.28.0; x86_64; ; ) In-Reply-To: <1503475207-30288-1-git-send-email-david.wu@rock-chips.com> References: <1503475207-30288-1-git-send-email-david.wu@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 513 Lines: 15 Am Mittwoch, 23. August 2017, 16:00:07 CEST schrieb David Wu: > The pins from GPIO1A0 to GPIO1B1 are special, need to recalculate > iomux. And the register offset is larger than the u8 range, so changed > to u32. > > Signed-off-by: David Wu While I'm still struggling trying to understand why some chip-designer would move these iomux settings into the general SOC_CON registers, this matches the documentation for the rv1108, so Reviewed-by: Heiko Stuebner Heiko