Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755085AbdHYJhB (ORCPT ); Fri, 25 Aug 2017 05:37:01 -0400 Received: from ozlabs.org ([103.22.144.67]:56729 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754848AbdHYJg7 (ORCPT ); Fri, 25 Aug 2017 05:36:59 -0400 From: Michael Ellerman To: Sukadev Bhattiprolu Cc: Benjamin Herrenschmidt , mikey@neuling.org, stewart@linux.vnet.ibm.com, apopple@au1.ibm.com, hbabu@us.ibm.com, oohall@gmail.com, linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 07/12] powerpc/vas: Define vas_win_paste_addr() In-Reply-To: <1503556688-15412-8-git-send-email-sukadev@linux.vnet.ibm.com> References: <1503556688-15412-1-git-send-email-sukadev@linux.vnet.ibm.com> <1503556688-15412-8-git-send-email-sukadev@linux.vnet.ibm.com> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Fri, 25 Aug 2017 19:36:57 +1000 Message-ID: <8760dcugxy.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 741 Lines: 17 Sukadev Bhattiprolu writes: > Define an interface that the NX drivers can use to find the physical > paste address of a send window. This interface is expected to be used > with the mmap() operation of the NX driver's device. i.e the user space > process can use driver's mmap() operation to map the send window's paste > address into their address space and then use copy and paste instructions > to submit the CRBs to the NX engine. > > Note that kernel drivers will use vas_paste_crb() directly and don't need > this interface. AFAICS this is not used. And if it was that would be a problem because there are implications in letting userspace do paste, so can you drop this from the series for now. cheers