Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932971AbdHYN4z (ORCPT ); Fri, 25 Aug 2017 09:56:55 -0400 Received: from mga14.intel.com ([192.55.52.115]:21135 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756299AbdHYN4w (ORCPT ); Fri, 25 Aug 2017 09:56:52 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,425,1498546800"; d="scan'208";a="1007603294" Message-ID: <1503669407.25945.102.camel@linux.intel.com> Subject: Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs From: Andy Shevchenko To: Tom Rini , linux-kernel@vger.kernel.org, John Keeping Cc: Bard Liao , Oder Chiou , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, Mark Brown , Linus Torvalds Date: Fri, 25 Aug 2017 16:56:47 +0300 In-Reply-To: <1503453106-5564-1-git-send-email-trini@konsulko.com> References: <1503453106-5564-1-git-send-email-trini@konsulko.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 791 Lines: 25 +John On Tue, 2017-08-22 at 21:51 -0400, Tom Rini wrote: > Not all devices with ACPI and this combination of sound devices will > have the required information provided via ACPI.  Reintroduce the I2C > device ID to restore sound functionality on on the Chromebook 'Samus' > model. Tom, one more question. Apparently you are the one who tested the commit 89128534f925 ("ASoC: rt5677: Add ACPI support") year ago. The commit states that ACPI properties that are used in Chromebook Pixel 2015 is non-standard (not the same as for DT). However, DSDT shows the opposite! I would like to ask yuo and John what is the status of that currently? Do we have any publicly available laptop with non-standard properties? -- Andy Shevchenko Intel Finland Oy