Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932692AbdHYOWd (ORCPT ); Fri, 25 Aug 2017 10:22:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:55808 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932562AbdHYOWb (ORCPT ); Fri, 25 Aug 2017 10:22:31 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC8DB21A1A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Fri, 25 Aug 2017 10:22:29 -0400 From: Steven Rostedt To: "Ziqian SUN (Zamir)" Cc: linux-kernel@vger.kernel.org, jkacur@redhat.com Subject: Re: [PATCH] trace-cmd report: Fix hash.key in option -w Message-ID: <20170825102229.1efedf40@gandalf.local.home> In-Reply-To: <1503640069-23069-1-git-send-email-zsun@redhat.com> References: <1503640069-23069-1-git-send-email-zsun@redhat.com> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1057 Lines: 31 On Fri, 25 Aug 2017 13:47:49 +0800 "Ziqian SUN (Zamir)" wrote: > From: "Ziqian SUN (Zamir)" > > In add_wakeup function the hash list is created with hash.key = value. > This makes add_sched function will never find a match with the key which > results in trace-cmd report will never show the average latency with the > following command: > trace-cmd report -w -F 'sched_switch,sched_wakeup' > With this patch, the command will show average latency as it used to be > in v2.4.2 like > > Average wakeup latency: 28.460 usecs > Maximum Latency: 669.268 usecs at timestamp: 16337.629767 > Minimum Latency: 2.153 usecs at timestamp: 16337.533735 > > RT task timings: > > Average wakeup latency: 23.106 usecs > Maximum Latency: 57.482 usecs at timestamp: 16337.187531 > Minimum Latency: 4.127 usecs at timestamp: 16336.945209 > > Reported-by: Joe Mario > Signed-off-by: Ziqian SUN (Zamir) Thanks a lot Ziqian! Added. Will push out soon. I need to update the stables too. -- Steve