Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756884AbdHYOgu (ORCPT ); Fri, 25 Aug 2017 10:36:50 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:50477 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756858AbdHYOgr (ORCPT ); Fri, 25 Aug 2017 10:36:47 -0400 Subject: Re: [PATCH 3/7] ieee802154: 6lowpan: make header_ops const To: Bhumika Goyal , julia.lawall@lip6.fr, marcel@holtmann.org, gustavo@padovan.org, johan.hedberg@gmail.com, davem@davemloft.net, pablo@netfilter.org, kadlec@blackhole.kfki.hu, fw@strlen.de, stephen@networkplumber.org, alex.aring@gmail.com, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, santosh.shilimkar@oracle.com, trond.myklebust@primarydata.com, anna.schumaker@netapp.com, bfields@fieldses.org, jlayton@poochiereds.net, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, bridge@lists.linux-foundation.org, linux-wpan@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-nfs@vger.kernel.org References: <1503670907-23221-1-git-send-email-bhumirks@gmail.com> <1503670907-23221-4-git-send-email-bhumirks@gmail.com> From: Stefan Schmidt Message-ID: Date: Fri, 25 Aug 2017 16:36:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1503670907-23221-4-git-send-email-bhumirks@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 783 Lines: 30 Hello. On 08/25/2017 04:21 PM, Bhumika Goyal wrote: > Make this const as it is only stored as a reference in a const field of > a net_device structure. > > Signed-off-by: Bhumika Goyal > --- > net/ieee802154/6lowpan/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/ieee802154/6lowpan/core.c b/net/ieee802154/6lowpan/core.c > index de2661c..974765b 100644 > --- a/net/ieee802154/6lowpan/core.c > +++ b/net/ieee802154/6lowpan/core.c > @@ -54,7 +54,7 @@ > > static int open_count; > > -static struct header_ops lowpan_header_ops = { > +static const struct header_ops lowpan_header_ops = { > .create = lowpan_header_create, > }; > > Acked-by: Stefan Schmidt regards Stefan Schmidt