Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933386AbdHYO5Y (ORCPT ); Fri, 25 Aug 2017 10:57:24 -0400 Received: from mail-qk0-f179.google.com ([209.85.220.179]:32969 "EHLO mail-qk0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932602AbdHYO5X (ORCPT ); Fri, 25 Aug 2017 10:57:23 -0400 MIME-Version: 1.0 In-Reply-To: References: <1501737812-24171-1-git-send-email-jacob-chen@iotwrt.com> From: Jacob Chen Date: Fri, 25 Aug 2017 22:57:21 +0800 Message-ID: Subject: Re: [PATCH v7] rockchip/rga: v4l2 m2m support To: Hans Verkuil Cc: "open list:ARM/Rockchip SoC..." , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Heiko Stuebner , Mauro Carvalho Chehab , Linux Media Mailing List , laurent.pinchart+renesas@ideasonboard.com, Hans Verkuil , Tomasz Figa , Nicolas Dufresne Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1459 Lines: 47 Hi Hans, 2017-08-21 22:16 GMT+08:00 Hans Verkuil : > Hi Jacob, > > On 08/03/2017 07:23 AM, Jacob Chen wrote: >> Rockchip RGA is a separate 2D raster graphic acceleration unit. It >> accelerates 2D graphics operations, such as point/line drawing, image >> scaling, rotation, BitBLT, alpha blending and image blur/sharpness >> >> The drvier is mostly based on s5p-g2d v4l2 m2m driver >> And supports various operations from the rendering pipeline. >> - copy >> - fast solid color fill >> - rotation >> - flip >> - alpha blending >> >> The code in rga-hw.c is used to configure regs according to operations >> The code in rga-buf.c is used to create private mmu table for RGA. >> >> changes in V7: >> - fix some warning reported by "checkpatch --strict" >> >> Signed-off-by: Jacob Chen > > Can you post the v4l2-compliance output? I gather that there is at least one > colorspace-related error that appears to be a v4l2-compliance bug, so I'd > like to see the exact error it gives. I'll see if I can fix it so this driver > has a clean compliance output. > OK, i will post it. > I apologize that this driver probably won't make 4.14. Too much to review... > It doesn't matter, I'm still writing the userspace for this driver , At peresent this driver might have a lot of bugs, since i didn't test it much in production environment . > I hope to do the v7 review within a week. > > Regards, > > Hans