Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933706AbdHYPZp (ORCPT ); Fri, 25 Aug 2017 11:25:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:34158 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933386AbdHYPZn (ORCPT ); Fri, 25 Aug 2017 11:25:43 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD8DE21A1B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Fri, 25 Aug 2017 11:25:41 -0400 From: Steven Rostedt To: Eugeniy Paltsev Cc: "linux-kernel@vger.kernel.org" , "frowand.list@gmail.com" , "robh+dt@kernel.org" , "devicetree@vger.kernel.org" , "linux-snps-arc@lists.infradead.org" Subject: Re: [PATCH] OF: move extern declarations of entry pointers inside ifdef Message-ID: <20170825112541.681dafd2@gandalf.local.home> In-Reply-To: <1503674411.15555.5.camel@synopsys.com> References: <20170825150027.25341-1-Eugeniy.Paltsev@synopsys.com> <20170825111200.5f0891a5@gandalf.local.home> <1503674411.15555.5.camel@synopsys.com> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 826 Lines: 27 On Fri, 25 Aug 2017 15:20:12 +0000 Eugeniy Paltsev wrote: > On Fri, 2017-08-25 at 11:12 -0400, Steven Rostedt wrote: > > On Fri, 25 Aug 2017 18:00:26 +0300 > > Eugeniy Paltsev wrote: > > > > > Move extern declarations of "of_root", "of_chosen", "of_aliases", > > > "of_stdout" pointers inside "CONFIG_OF" ifdef to be able to get rid > > > of "CONFIG_OF" ifdef in their usage places. > > > > > > Suggested-by: Steven Rostedt > > > > Thanks! > > -- Steve > > Could you please ACK my patch if it looks good for you? > Thanks. I could, but ACKs are usually for the maintainer of the code being changed. I don't maintain include/linux/of.h But for what it's worth... Acked-by: Steven Rostedt (VMware) -- Steve