Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934012AbdHYP53 (ORCPT ); Fri, 25 Aug 2017 11:57:29 -0400 Received: from mout.web.de ([212.227.15.3]:55122 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933864AbdHYP51 (ORCPT ); Fri, 25 Aug 2017 11:57:27 -0400 Subject: [PATCH 03/14] vme: Move an assignment in vme_new_dma_list() From: SF Markus Elfring To: devel@driverdev.osuosl.org, Aaron Sierra , Alessio Igor Bogani , Arnd Bergmann , Augusto Mecking Caringi , Baoyou Xie , Greg Kroah-Hartman , Manohar Vanga , Martyn Welch Cc: LKML , kernel-janitors@vger.kernel.org References: <7ab4be89-4aa6-5537-9839-da090635f249@users.sourceforge.net> Message-ID: <296b53ad-dd93-255d-a69a-f48ced245af9@users.sourceforge.net> Date: Fri, 25 Aug 2017 17:57:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <7ab4be89-4aa6-5537-9839-da090635f249@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:6eZiyv5Z+Y6T2JbPzhDkk9B+Sp4mxxKVm0X9oEtK5GP8ZkNJ3nH 84c/7xny+FpYOV7dBEkMOwYaxjFYkHNkX+IFKmvWgSwDVlprurYJiVQOk3AGAoq6Fc6wGWL wgJTjoGOOllJXIU95LEGcR1PRpsFsVpRPu+aPzkSAmujCdfeJiV/y7xMEI/BIWjjFJUw4xR xvHkbn7Gt2B+jF9qkBiOQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:k8y8d8GJHl4=:hzsSh07Pbz9cjamOD/09vj +2kOgGUnr2jsLI03BU3pO07XQ5AZ53vtjgZxiCxacOdv8Ajug0bg7oI6qTtGZdXmlN9UhAuT9 54H4yAZoJ/WPXmmH/4PGsFMC90f9pA3a/aJ5NQJteUbywoSe55NsRLN6f/4grDDve4M4rNzkV mN8LAwLmpLrzNR8+I8x9yFylHcB5GpX+cAz7YkPRgRIclzKkG89Fo5hsrGVGT43XC+XYQWGhu UiMIEkCiozTCtzlRQU6K66QDeqNRXE+6YovqUNnRB2iGNaC7mlo8PfSG0nQJ2oZewQxCfL6p4 LE3HJPpmadbc9t0i6MBIV65OTVpBAZrz2NI9ISNYxohP5ULJVpM2TL3/hZt20WUhv2II1mjU4 DY4j7PdDAO8uE9i171gqntRlZtSfKKG+nhSJpjC4ozZRK82DX22nGBl1zvkml6Mo0MPaVEE+H EKxwnI8uo79Kj7ni6lXkzQ2HDpH7B3vqu4pr5OMZDEux82sbBtehtOV3ZTD3rBN4g+wshMRN4 FkF5wDZoiA1rT5ee8xiF/oGTu0wthOMva37bUv05EouG9KguAASeARVp7n1eHOYxgGOStOf3b eCTu95FbcDxIfICftrZlZA8o6vshthWAloyH8RZDexTIP+fwQ0TTJIdgBxLlXe6KkPeN2Rz0c nmAMFGmWMKntnjqJqo7P+8dUMcHdQysNDSKAa4blf8oiUVRM2OY9tNuv8ps5f3tegtpTOKfo5 +7eCTGhMGxwgLDZ5/LOHz8OiLzzWCVqqfhUz5i1k4NUt+jjsaXgg8F07RZoUOARwyKBVfluj5 Vpvpy7+0Pg//XZTJNQOVd/+miEQiPOMR/1WkLsFTeTV8j/7gXc= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1207 Lines: 43 From: Markus Elfring Date: Thu, 24 Aug 2017 22:04:45 +0200 Assign a pointer to a data structure member without using an intermediate local variable. Signed-off-by: Markus Elfring --- drivers/vme/vme.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/vme/vme.c b/drivers/vme/vme.c index 1afddf5eafd4..d890410e472d 100644 --- a/drivers/vme/vme.c +++ b/drivers/vme/vme.c @@ -948,7 +948,6 @@ EXPORT_SYMBOL(vme_dma_request); */ struct vme_dma_list *vme_new_dma_list(struct vme_resource *resource) { - struct vme_dma_resource *ctrlr; struct vme_dma_list *dma_list; if (resource->type != VME_DMA) { @@ -956,14 +955,14 @@ struct vme_dma_list *vme_new_dma_list(struct vme_resource *resource) return NULL; } - ctrlr = list_entry(resource->entry, struct vme_dma_resource, list); - dma_list = kmalloc(sizeof(*dma_list), GFP_KERNEL); if (!dma_list) return NULL; INIT_LIST_HEAD(&dma_list->entries); - dma_list->parent = ctrlr; + dma_list->parent = list_entry(resource->entry, + struct vme_dma_resource, + list); mutex_init(&dma_list->mtx); return dma_list; -- 2.14.0