Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934173AbdHYQAw (ORCPT ); Fri, 25 Aug 2017 12:00:52 -0400 Received: from mout.web.de ([212.227.15.3]:63283 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933919AbdHYQAu (ORCPT ); Fri, 25 Aug 2017 12:00:50 -0400 Subject: [PATCH 05/14] vme: Return directly in two functions From: SF Markus Elfring To: devel@driverdev.osuosl.org, Aaron Sierra , Alessio Igor Bogani , Arnd Bergmann , Augusto Mecking Caringi , Baoyou Xie , Greg Kroah-Hartman , Manohar Vanga , Martyn Welch Cc: LKML , kernel-janitors@vger.kernel.org References: <7ab4be89-4aa6-5537-9839-da090635f249@users.sourceforge.net> Message-ID: Date: Fri, 25 Aug 2017 18:00:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <7ab4be89-4aa6-5537-9839-da090635f249@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:r+M/ZiEn+gVORTsx9/mlhqH3bpZ7sbiX4PgX76csRQdcjmljijq JuLTRNMI5rk56B5qRxFvMTdH+QadTdJkr4huZZWUNPZJirWHAdN4SrhdF9ZYoHA2pkoUhti FLWFNj8uUXgUm4DDzhUHlh1A33bALwSuDKahzJGq3c/S+ngGLh4ArW9MAV8qCdYazfB7ZXy tCgCmrhKnw6Dr0oXTLjjw== X-UI-Out-Filterresults: notjunk:1;V01:K0:2JbEdcHFpY8=:d0akExbbpK3lNwKlUlVUrC IrtATwlH19ZTzAdb01zzuYoai0N3W48nFTW3YSLDt2w1PfWmbjGLA3QdwwlbGMguIHEE5fQLD bC+c1RTp/7/wlfPnyvNRPdkUwOUzZ1VpYK1MyZ7n2/QXmBGX8Iz9N+N5FEGLTAVsRj79dT4l6 qm6M0DYPyP2Vwzf49QKnXwXAvqvL/OwTxsEJ3abO9z5eGlBOORgGafisI86GG3U5BF0ZNHMRc v0SyOtIXFEMp8rREB+OZ58AXoAtlmkwz030k1ekpTGbGmZ+XC5+RdFmWotYP6gEFKFUmb9ipf eUp1LpI69Gjz1Ho/vkMnnY/rpWP9BWRc8NV+nfazDBl2e8wuDiXf4UuzfkZMgEUj2wEYIwbsO RmKPr6YnI4XtDzfYYsdyTdROkbDvU7yL6D17hmsUjoUwU2vVVTUmSZHLT1Up45dnJVoydNvQK oFDvfktpktUD/vUprJNzvUYmbFNpNu0TPK1rS0l0nGsWUxajeV3Y+MsnEvdYEB0fZFcWjbY2B Xi8qD0JjNbalaP7IxXZX3CNC0TXeJZv7SGaF7bFmN+2148vKpvtrFTpzONvXcrYU1tkXZl0si ckQQup480baT6aOjJevIM+Pi1fRrv1DlFCtQdprTzMTX8q+r+W0vwsqimEpi0DmOJNl1qRcfb 60+2BIBcxlpVr8mz0ixg46TTdUN1BrIqPnqVYLcDG6LG1uFn0tvLIommjZbNB0QndiuHjDFCu PsDI9Gut/pR1Wx1ucHR5XOrmn5jqwnIhRPUV6rot7LwF26ASYYGHYc9Qyege4/E8ET1VAcH6P Mx5StN/K6vgfradefR/mKVERKShL7GKi84YVmG68dUzu4u2RPs= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1227 Lines: 50 From: Markus Elfring Date: Thu, 24 Aug 2017 22:32:14 +0200 Return directly without using an intermediate local variable in these functions. Signed-off-by: Markus Elfring --- drivers/vme/vme.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/vme/vme.c b/drivers/vme/vme.c index a2e36e6a0d84..986799d64993 100644 --- a/drivers/vme/vme.c +++ b/drivers/vme/vme.c @@ -1996,28 +1996,26 @@ static int vme_bus_match(struct device *dev, struct device_driver *drv) static int vme_bus_probe(struct device *dev) { - int retval = -ENODEV; struct vme_driver *driver; struct vme_dev *vdev = dev_to_vme_dev(dev); driver = dev->platform_data; if (driver->probe) - retval = driver->probe(vdev); + return driver->probe(vdev); - return retval; + return -ENODEV; } static int vme_bus_remove(struct device *dev) { - int retval = -ENODEV; struct vme_driver *driver; struct vme_dev *vdev = dev_to_vme_dev(dev); driver = dev->platform_data; if (driver->remove) - retval = driver->remove(vdev); + return driver->remove(vdev); - return retval; + return -ENODEV; } struct bus_type vme_bus_type = { -- 2.14.0