Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934365AbdHYQUR (ORCPT ); Fri, 25 Aug 2017 12:20:17 -0400 Received: from mail-lf0-f49.google.com ([209.85.215.49]:37058 "EHLO mail-lf0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933738AbdHYQUO (ORCPT ); Fri, 25 Aug 2017 12:20:14 -0400 MIME-Version: 1.0 In-Reply-To: <1503592565-21601-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1503592565-21601-1-git-send-email-arvind.yadav.cs@gmail.com> From: Mathieu Poirier Date: Fri, 25 Aug 2017 10:20:12 -0600 Message-ID: Subject: Re: [PATCH 0/9] constify amba_id To: Arvind Yadav Cc: Greg KH , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1742 Lines: 40 On 24 August 2017 at 10:35, Arvind Yadav wrote: > amba_id are not supposed to change at runtime. All functions > working with const amba_id. So mark the non-const structs as const. The real explanation here is that coresight IDs are only referenced in the amba driver declaration where the "id_table" field of struct amba_driver is a const. Given the widespread usage of the pattern I would have expected this set to be part of a wide effort. Also did you find this manually or by using a tool? If so please provide a description of what that tool is. Thanks, Mathieu > > Arvind Yadav (9): > [PATCH 1/9] coresight: constify amba_id > [PATCH 2/9] coresight: etb10: constify amba_id > [PATCH 3/9] coresight: etm3x: constify amba_id > [PATCH 4/9] coresight: etm4x: constify amba_id > [PATCH 5/9] coresight: funnel: constify amba_id > [PATCH 6/9] coresight: replicator: constify amba_id > [PATCH 7/9] coresight: stm: constify amba_id > [PATCH 8/9] coresight: tmc: constify amba_id > [PATCH 9/9] coresight: tpiu: constify amba_id > > drivers/hwtracing/coresight/coresight-cpu-debug.c | 2 +- > drivers/hwtracing/coresight/coresight-etb10.c | 2 +- > drivers/hwtracing/coresight/coresight-etm3x.c | 2 +- > drivers/hwtracing/coresight/coresight-etm4x.c | 2 +- > drivers/hwtracing/coresight/coresight-funnel.c | 2 +- > drivers/hwtracing/coresight/coresight-replicator-qcom.c | 2 +- > drivers/hwtracing/coresight/coresight-stm.c | 2 +- > drivers/hwtracing/coresight/coresight-tmc.c | 2 +- > drivers/hwtracing/coresight/coresight-tpiu.c | 2 +- > 9 files changed, 9 insertions(+), 9 deletions(-) > > -- > 2.7.4 >