Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754741AbdHYQw4 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 25 Aug 2017 12:52:56 -0400
Received: from quartz.orcorp.ca ([184.70.90.242]:56360 "EHLO quartz.orcorp.ca"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751869AbdHYQwz (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 25 Aug 2017 12:52:55 -0400
Date: Fri, 25 Aug 2017 10:52:42 -0600
From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Colin King <colin.king@canonical.com>
Cc: Peter Huewe <peterhuewe@gmx.de>, Marcel Selhorst <tpmdd@selhorst.net>,
        Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
        tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tpm_tis: make array cmd_getticks static const to shink
 object code size
Message-ID: <20170825165242.GA5254@obsidianresearch.com>
References: <20170825164505.23447-1-colin.king@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170825164505.23447-1-colin.king@canonical.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 653
Lines: 19

On Fri, Aug 25, 2017 at 05:45:05PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Don't populate array cmd_getticks on the stack, instead make it static
> const.  Makes the object code smaller by over 160 bytes:
> 
> Before:
>    text	   data	    bss	    dec	    hex	filename
>   18813	   3152	    128	  22093	   564d	drivers/char/tpm/tpm_tis_core.o
> 
> After:
>    text	   data	    bss	    dec	    hex	filename
>   18554	   3248	    128	  21930	   55aa	drivers/char/tpm/tpm_tis_core.o
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>

Jason