Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757366AbdHYRb2 (ORCPT ); Fri, 25 Aug 2017 13:31:28 -0400 Received: from mga02.intel.com ([134.134.136.20]:31557 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757347AbdHYRb0 (ORCPT ); Fri, 25 Aug 2017 13:31:26 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,426,1498546800"; d="scan'208";a="143948168" Date: Fri, 25 Aug 2017 20:31:20 +0300 From: Jarkko Sakkinen To: Jason Gunthorpe Cc: Colin King , Peter Huewe , Marcel Selhorst , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tpm_tis: make array cmd_getticks static const to shink object code size Message-ID: <20170825173120.l2mp4tckdtyixzii@linux.intel.com> References: <20170825164505.23447-1-colin.king@canonical.com> <20170825165242.GA5254@obsidianresearch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170825165242.GA5254@obsidianresearch.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 829 Lines: 24 On Fri, Aug 25, 2017 at 10:52:42AM -0600, Jason Gunthorpe wrote: > On Fri, Aug 25, 2017 at 05:45:05PM +0100, Colin King wrote: > > From: Colin Ian King > > > > Don't populate array cmd_getticks on the stack, instead make it static > > const. Makes the object code smaller by over 160 bytes: > > > > Before: > > text data bss dec hex filename > > 18813 3152 128 22093 564d drivers/char/tpm/tpm_tis_core.o > > > > After: > > text data bss dec hex filename > > 18554 3248 128 21930 55aa drivers/char/tpm/tpm_tis_core.o > > > > Signed-off-by: Colin Ian King > > Reviewed-by: Jason Gunthorpe > > Jason Reviewed-by: Jarkko Sakkinen /Jarkko