Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757380AbdHYRfK (ORCPT ); Fri, 25 Aug 2017 13:35:10 -0400 Received: from mga01.intel.com ([192.55.52.88]:34253 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755568AbdHYRfJ (ORCPT ); Fri, 25 Aug 2017 13:35:09 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,426,1498546800"; d="scan'208";a="122613851" Date: Fri, 25 Aug 2017 20:35:02 +0300 From: Jarkko Sakkinen To: Jiandi An Cc: Jason Gunthorpe , peterhuewe@gmx.de, tpmdd@selhorst.net, tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH] tpm/tpm_crb: Access locality for non-ACPI and non-SMC start method Message-ID: <20170825173502.q5oc3uovpvzi65dm@linux.intel.com> References: <1503029736-591-1-git-send-email-anjiandi@codeaurora.org> <20170822173956.zpqe4scdnv7plrhj@linux.intel.com> <20170824122630.75sxjmkj5f7p7tv5@linux.intel.com> <7478e964-6553-9d1e-3d8f-83b044a9a562@codeaurora.org> <20170825162139.s5oasztecntzg223@linux.intel.com> <20170825165309.GB5254@obsidianresearch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 685 Lines: 22 On Fri, Aug 25, 2017 at 12:28:21PM -0500, Jiandi An wrote: > > > On 08/25/2017 11:53 AM, Jason Gunthorpe wrote: > > On Fri, Aug 25, 2017 at 07:21:39PM +0300, Jarkko Sakkinen wrote: > > > As I said before it would make much more sense to make code always deal > > > with sm and remove flags completely. That would help maintaining code > > > easier as new logic for TZ is introduced. > > > > Yes please > > > > Jason > > > Okay, I'll work on moving sm to priv and getting rid of flags from > priv. Will submit a new patch with appropriate patch name and not > a v2 of this patch since the scope of changes have changed. > > Thanks for your comments and feedback. Great /Jarkko