Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757912AbdHYR7t (ORCPT ); Fri, 25 Aug 2017 13:59:49 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:35241 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757682AbdHYR7q (ORCPT ); Fri, 25 Aug 2017 13:59:46 -0400 Subject: Re: [PATCH 0/9] constify amba_id To: Mathieu Poirier References: <1503592565-21601-1-git-send-email-arvind.yadav.cs@gmail.com> Cc: Greg KH , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" From: arvind Message-ID: <59A0658C.8070404@gmail.com> Date: Fri, 25 Aug 2017 23:29:40 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1985 Lines: 44 Hi, On Friday 25 August 2017 09:50 PM, Mathieu Poirier wrote: > On 24 August 2017 at 10:35, Arvind Yadav wrote: >> amba_id are not supposed to change at runtime. All functions >> working with const amba_id. So mark the non-const structs as const. > The real explanation here is that coresight IDs are only referenced in > the amba driver declaration where the "id_table" field of struct > amba_driver is a const. Given the widespread usage of the pattern I > would have expected this set to be part of a wide effort. Also did > you find this manually or by using a tool? If so please provide a > description of what that tool is. I am not using any tools. I have push same change for other subsystem. So I thought to change coresight ids. > > Thanks, > Mathieu > >> Arvind Yadav (9): >> [PATCH 1/9] coresight: constify amba_id >> [PATCH 2/9] coresight: etb10: constify amba_id >> [PATCH 3/9] coresight: etm3x: constify amba_id >> [PATCH 4/9] coresight: etm4x: constify amba_id >> [PATCH 5/9] coresight: funnel: constify amba_id >> [PATCH 6/9] coresight: replicator: constify amba_id >> [PATCH 7/9] coresight: stm: constify amba_id >> [PATCH 8/9] coresight: tmc: constify amba_id >> [PATCH 9/9] coresight: tpiu: constify amba_id >> >> drivers/hwtracing/coresight/coresight-cpu-debug.c | 2 +- >> drivers/hwtracing/coresight/coresight-etb10.c | 2 +- >> drivers/hwtracing/coresight/coresight-etm3x.c | 2 +- >> drivers/hwtracing/coresight/coresight-etm4x.c | 2 +- >> drivers/hwtracing/coresight/coresight-funnel.c | 2 +- >> drivers/hwtracing/coresight/coresight-replicator-qcom.c | 2 +- >> drivers/hwtracing/coresight/coresight-stm.c | 2 +- >> drivers/hwtracing/coresight/coresight-tmc.c | 2 +- >> drivers/hwtracing/coresight/coresight-tpiu.c | 2 +- >> 9 files changed, 9 insertions(+), 9 deletions(-) >> >> -- >> 2.7.4 >> ~arvind