Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933705AbdHYU52 (ORCPT ); Fri, 25 Aug 2017 16:57:28 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:37553 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932319AbdHYU50 (ORCPT ); Fri, 25 Aug 2017 16:57:26 -0400 Date: Fri, 25 Aug 2017 21:57:22 +0100 From: Martyn Welch To: SF Markus Elfring Cc: devel@driverdev.osuosl.org, Aaron Sierra , Alessio Igor Bogani , Arnd Bergmann , Augusto Mecking Caringi , Baoyou Xie , Greg Kroah-Hartman , Manohar Vanga , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 13/14] vme: tsi148: Improve 17 size determinations Message-ID: <20170825205721.GA11181@hades.home> References: <7ab4be89-4aa6-5537-9839-da090635f249@users.sourceforge.net> <1cb8956d-2862-9f64-d19c-32b4a797a3b1@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1cb8956d-2862-9f64-d19c-32b4a797a3b1@users.sourceforge.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 447 Lines: 14 On Fri, Aug 25, 2017 at 06:15:08PM +0200, SF Markus Elfring wrote: > @@ -2363,5 +2364,5 @@ static int tsi148_probe(struct pci_dev *pdev, const struct pci_device_id *id) > master_num--; > > tsi148_device->flush_image = > - kmalloc(sizeof(struct vme_master_resource), GFP_KERNEL); > + kmalloc(sizeof(*tsi148_device->flush_image), GFP_KERNEL); This line is now a tiny bit too long and needs to be broken over two lines. Martyn