MIME-Version: 1.0
In-Reply-To: <CALAqxLW4CUaz_DSdygkQvpHmEecadNASc353RSr2LO0J0a+xUw@mail.gmail.com>
References: <1495856035-6622-1-git-send-email-john.stultz@linaro.org>
 <1495856035-6622-5-git-send-email-john.stultz@linaro.org> <150366841319.27971.6041120504203143444@mail.alporthouse.com>
 <CALAqxLW4CUaz_DSdygkQvpHmEecadNASc353RSr2LO0J0a+xUw@mail.gmail.com>
From: John Stultz <john.stultz@linaro.org>
Date: Fri, 25 Aug 2017 14:16:57 -0700
Message-ID: <CALAqxLW62Y73siURh=f26qOep48K8QdM_AjrkdOShCNQ69p6ww@mail.gmail.com>
Subject: Re: [RFC][PATCH 4/4] time: Clean up CLOCK_MONOTONIC_RAW time handling
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: lkml <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@kernel.org>,
        Miroslav Lichvar <mlichvar@redhat.com>,
        Richard Cochran <richardcochran@gmail.com>,
        Prarit Bhargava <prarit@redhat.com>,
        Stephen Boyd <stephen.boyd@linaro.org>,
        Kevin Brodsky <kevin.brodsky@arm.com>,
        Will Deacon <will.deacon@arm.com>,
        Daniel Mentz <danielmentz@google.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 841
Lines: 19

On Fri, Aug 25, 2017 at 11:55 AM, John Stultz <john.stultz@linaro.org> wrote:
> I'll look over the code again to see if I can catch anything by
> review. Worse case if we can't get any traction on this in a day or so
> I'll submit a revert.

I think I found the issue. In tk_update_ktime_data() I add the raw_sec
and shifted down  tk->tkr_raw.xtime_nsec to the base. But we already
add the tk->tkr_raw.xtime_nsec to the offset and shift it all down in
the timekeeping_delta_to_ns called from ktime_get_raw, so we
effectively are accumulating the nsecs portion faster then we should.

This only crops up for internal ktime_get_raw() users, but not
getrawmonotonic64() which uses the timespec generation rather then the
ktime method, which is why this wasn't seen by userspace time tests.

I'll send a patch for testing shortly.

thanks
-john