Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754750AbdHZAdY (ORCPT ); Fri, 25 Aug 2017 20:33:24 -0400 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:52638 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754171AbdHZAdW (ORCPT ); Fri, 25 Aug 2017 20:33:22 -0400 Message-ID: <1503707590.3688.64.camel@decadent.org.uk> Subject: Re: [PATCH 3.16 119/134] ipv4: restore rt->fi for reference counting From: Ben Hutchings To: Eric Dumazet Cc: LKML , stable@vger.kernel.org, Andrew Morton , "David S. Miller" , Andrey Konovalov , WANG Cong Date: Sat, 26 Aug 2017 01:33:10 +0100 In-Reply-To: References: Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-JuIqiz4JTYiD48KG0lgJ" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 2a02:8011:400e:2:6f00:88c8:c921:d332 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2232 Lines: 66 --=-JuIqiz4JTYiD48KG0lgJ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2017-08-18 at 06:53 -0700, Eric Dumazet wrote: > > On Fri, Aug 18, 2017 at 6:13 AM, Ben Hutchings wr= ote: > > 3.16.47-rc1 review patch.=C2=A0=C2=A0If anyone has any objections, plea= se let me know. > >=20 > > ------------------ > >=20 > > From: WANG Cong > >=20 > > commit 82486aa6f1b9bc8145e6d0fa2bc0b44307f3b875 upstream. [...] > I thought we refined this later with : In fact it was reverted upstream, then replaced by the commits you point out. Thanks; I don't know why I missed that. > commit 3fb07daff8e99243366a081e5129560734de4ada > Author: Eric Dumazet > Date:=C2=A0=C2=A0=C2=A0Thu May 25 14:27:35 2017 -0700 >=20 > =C2=A0=C2=A0=C2=A0=C2=A0ipv4: add reference counting to metrics [...] It's not obvious how to backport this, as it adds: +#define DST_METRICS_REFCOUNTED 0x2UL but 3.16 already has a flag with value 2. I don't think we can take another bit from the pointer as metrics are only 32-bit aligned. Ben. --=20 Ben Hutchings One of the nice things about standards is that there are so many of them. --=-JuIqiz4JTYiD48KG0lgJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEErCspvTSmr92z9o8157/I7JWGEQkFAlmgwcYACgkQ57/I7JWG EQm71xAAqMFJMgMpVqjs4ja0+OmdD0hQ0xkZmTN1FY7pBbzw6sJd4J359cmvfKHt JPOJvkWfOHzQnHJdPPQUyobJnFDEY73QaTykWn9RBkf3GjyhNqdklogBJ+7jwwag 9sCkm55jFwhRVJjVnJGA6fjDiK9IZLdZaqD793p6G/HpvCPdLN9/gg6cqC0KKOFJ o0UJzHd+2yjEZYPTobvl8Qohi0KHyrhnj/5lflMCLLzg21EIO8z/9ZHdMKNJK2w6 xfxopncWoYM5WpBr37lBivZ52Jm8GswIAheUaYPaVHuyCBSSzaTRlkNXoD00ffdn eIxDdPvUa5uxE7dH/UOUepJTcNN4QU0gud4E+ZMjT7bod8bSdK3vS3okLD3QdEki /ulsgDujOiNd4zG31oXLKrQ7SOFeoJocqjuXp6jKYSD9Oo4iuPSAp8rDPym98gMo oLPaCf/MAGaLsCbd1qzAOQxSOgQjRW2xEpT9+ZncXXvF19Ry2xLBypTMybLwzeeN yFctQWQ5sdHauTe9d+I6j6z+2LlBFDE3FOk+HYn1r6P9tqSZVmrLCGOOZCwYQ5Mp YsrgP7d5x2ApwJ7EsmcE4+pJHH0wFcBU6jSlPFAGpLvxA0Y/6t7zlRKTMf1a24IL tuPyuFN7tcpMkVtwtjVigG63ysBmS4eQXf3TqL9L5v7zql+7JCY= =N+LT -----END PGP SIGNATURE----- --=-JuIqiz4JTYiD48KG0lgJ--