Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754240AbdHZAhJ (ORCPT ); Fri, 25 Aug 2017 20:37:09 -0400 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:52668 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751409AbdHZAhI (ORCPT ); Fri, 25 Aug 2017 20:37:08 -0400 Message-ID: <1503707820.3688.67.camel@decadent.org.uk> Subject: Re: [PATCH 3.16 084/134] usb: misc: legousbtower: Fix buffers on stack From: Ben Hutchings To: Maksim Salau Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, akpm@linux-foundation.org, Alfredo Rafael Vicente Boix , Greg Kroah-Hartman Date: Sat, 26 Aug 2017 01:37:00 +0100 In-Reply-To: <20170819092940.62513d5c@gmail.com> References: <20170819092940.62513d5c@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-5vPICfHKE4d8L31btMj+" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 2a02:8011:400e:2:6f00:88c8:c921:d332 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1945 Lines: 59 --=-5vPICfHKE4d8L31btMj+ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 2017-08-19 at 09:29 +0300, Maksim Salau wrote: > On Fri, 18 Aug 2017 14:13:20 +0100 > Ben Hutchings wrote: >=20 > > 3.16.47-rc1 review patch.=C2=A0=C2=A0If anyone has any objections, plea= se let me know. > >=20 > > ------------------ > >=20 > > From: Maksim Salau > >=20 > > commit 942a48730faf149ccbf3e12ac718aee120bb3529 upstream. > >=20 > > Allocate buffers on HEAP instead of STACK for local structures > > that are to be received using usb_control_msg(). >=20 > Hi Ben, >=20 > The change has a memory leak, which is fixed by the commit > 0bd193d62b4270a2a7a09da43ad1034c7ca5b3d3 > If the commit is not in your queue, please add it. Thanks, I've added this. Ben. --=20 Ben Hutchings One of the nice things about standards is that there are so many of them. --=-5vPICfHKE4d8L31btMj+ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEErCspvTSmr92z9o8157/I7JWGEQkFAlmgwq0ACgkQ57/I7JWG EQnc1hAAuPCHiWc0M/5WKob0/TyHWQDi2LjJeyJw9+jZwmSZT8YTmMac2T5amysm FwihC1NLwP6l4kCs8SN31xiM+x84xT/CZ4dvijIKjs64s5z0zoXZnxHLI5Dib6oX zOfHUdTAU9lCrpqI/O7dyWZUHLr4SefxIn4fp+O0UQD1mRarWFVefB8saCgAMlJV ToYHbXbo7p84ToYyjNdxCOOYSrrfkSqyCOxHFw38yqPFSiqu41gTttoYqHPDZUmj R9J5iZVgb0hP6zFoSFfjO6IckVvOCgGco9FID5Fc7CRGcdxJPh4oYRbEZnzUjm7S 82qv8WQlS708fkj0RK1WPfUJWnKAYbrqKXJVmvqNtngjk+5gV3otSE8AOz52R5FV iTU9+7TBYrBrvIDCEUzylrlDl8V2aJvjQZS5k5qp7/AeWNCL3YRdqE5o1Qu8TdX+ Q4NauBsHY0roNCiotoii7j3Ls48IshXXTp6xmoUnEl8Ein8wvFII0IlHGJfJs8v1 LTIMNx5IiAxjYoZSnT1Ud9RlgFDyeNEz33Pp+At+kAYZP7hCmAXx6vtHr+P+Kzsx k9l+16r/cqgD5pdTM05HA77hnBVE3bWAzdsOYqTQUTydnyACBrROs54kN9gwLgHI K9SSEtVtjS6b/55EyPiW73muUvOeyVXuBLtp4K60N+4OOkWFtns= =X05A -----END PGP SIGNATURE----- --=-5vPICfHKE4d8L31btMj+--