Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754630AbdHZBBP (ORCPT ); Fri, 25 Aug 2017 21:01:15 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:5458 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754250AbdHZBBL (ORCPT ); Fri, 25 Aug 2017 21:01:11 -0400 Message-ID: <59A0C813.2060201@huawei.com> Date: Sat, 26 Aug 2017 09:00:03 +0800 From: Shannon Zhao User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: gengdongjiu , , , , , , , , , , , , , , , , , , , , , , , , , , , , , CC: , , , Subject: Re: [PATCH v11 1/6] ACPI: add APEI/HEST/CPER structures and macros References: <1503066227-18251-1-git-send-email-gengdongjiu@huawei.com> <1503066227-18251-2-git-send-email-gengdongjiu@huawei.com> <599EC7AB.3080604@huawei.com> <69090a96-ce90-4b2b-a419-c8d847d56093@huawei.com> In-Reply-To: <69090a96-ce90-4b2b-a419-c8d847d56093@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.16.142] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090205.59A0C824.0040,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 3dc7720de09a1a930da2bd11f60d6ba9 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1571 Lines: 38 On 2017/8/25 18:37, gengdongjiu wrote: >>> + >>> >> +/* From the ACPI 6.1 spec, "18.3.2.9 Hardware Error Notification" */ >>> >> + >> > It's better to refer to the first spec version of this structure and >> > same with others you define. > do you mean which spec version? the definition is aligned with the linux kernel. What I mean here is that it's better to refer to the ACPI spec version which introduces Hardware Error Notification first time. >> > >>> >> +enum AcpiHestNotifyType { >>> >> + ACPI_HEST_NOTIFY_POLLED = 0, >>> >> + ACPI_HEST_NOTIFY_EXTERNAL = 1, >>> >> + ACPI_HEST_NOTIFY_LOCAL = 2, >>> >> + ACPI_HEST_NOTIFY_SCI = 3, >>> >> + ACPI_HEST_NOTIFY_NMI = 4, >>> >> + ACPI_HEST_NOTIFY_CMCI = 5, /* ACPI 5.0 */ >>> >> + ACPI_HEST_NOTIFY_MCE = 6, /* ACPI 5.0 */ >>> >> + ACPI_HEST_NOTIFY_GPIO = 7, /* ACPI 6.0 */ >>> >> + ACPI_HEST_NOTIFY_SEA = 8, /* ACPI 6.1 */ >>> >> + ACPI_HEST_NOTIFY_SEI = 9, /* ACPI 6.1 */ >>> >> + ACPI_HEST_NOTIFY_GSIV = 10, /* ACPI 6.1 */ >>> >> + ACPI_HEST_NOTIFY_RESERVED = 11 /* 11 and greater are reserved */ >> > In ACPI 6.2, 11 is for Software Delegated Exception, is this useful for >> > your patchset? > it is usefull, for all the error source, I reserved the space for them. > Because the space is allocated one time, is not dynamically allocated. > so I use the ACPI_HEST_NOTIFY_RESERVED to specify that there is 11 error source. > I mean whether the new type Software Delegated Exception is useful for RAS. If so, we could add this new type here. Thanks, -- Shannon