Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754864AbdHZBHU (ORCPT ); Fri, 25 Aug 2017 21:07:20 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:33491 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754226AbdHZBHR (ORCPT ); Fri, 25 Aug 2017 21:07:17 -0400 Date: Fri, 25 Aug 2017 18:07:13 -0700 From: Alexei Starovoitov To: =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= Cc: Shuah Khan , linux-kernel@vger.kernel.org, Alexei Starovoitov , Andy Lutomirski , Arnaldo Carvalho de Melo , Casey Schaufler , Daniel Borkmann , David Drysdale , "David S . Miller" , "Eric W . Biederman" , James Morris , Jann Horn , Jonathan Corbet , Matthew Garrett , Michael Kerrisk , Kees Cook , Paul Moore , Sargun Dhillon , "Serge E . Hallyn" , Tejun Heo , Thomas Graf , Will Drewry , kernel-hardening@lists.openwall.com, linux-api@vger.kernel.org, linux-security-module@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next v7 01/10] selftest: Enhance kselftest_harness.h with a step mechanism Message-ID: <20170826010711.dksmgg4mcni5q2xd@ast-mbp> References: <20170821000933.13024-1-mic@digikod.net> <20170821000933.13024-2-mic@digikod.net> <20170824023105.gt6lyn2snhczryik@ast-mbp> <0e15da13-fad0-ba01-053c-1b4853e2bd6f@digikod.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0e15da13-fad0-ba01-053c-1b4853e2bd6f@digikod.net> User-Agent: NeoMutt/20170421 (1.8.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1726 Lines: 45 On Fri, Aug 25, 2017 at 09:58:33AM +0200, Micka?l Sala?n wrote: > > > On 24/08/2017 04:31, Alexei Starovoitov wrote: > > On Mon, Aug 21, 2017 at 02:09:24AM +0200, Micka?l Sala?n wrote: > >> This step mechanism may be useful to return an information about the > >> error without being able to write to TH_LOG_STREAM. > >> > >> Set _metadata->no_print to true to print this counter. > >> > >> Signed-off-by: Micka?l Sala?n > >> Cc: Andy Lutomirski > >> Cc: Arnaldo Carvalho de Melo > >> Cc: Kees Cook > >> Cc: Shuah Khan > >> Cc: Will Drewry > >> Link: https://lkml.kernel.org/r/CAGXu5j+D-FP8Kt9unNOqKrQJP4DYTpmgkJxWykZyrYiVPz3Y3Q@mail.gmail.com > >> --- > >> > >> This patch is intended to the kselftest tree: > >> https://lkml.kernel.org/r/20170806232337.4191-1-mic@digikod.net > >> > >> Changes since v6: > >> * add the step counter in assert/expect macros and use _metadata to > >> enable the counter (suggested by Kees Cook) > >> --- > >> tools/testing/selftests/kselftest_harness.h | 31 ++++++++++++++++++++++----- > >> tools/testing/selftests/seccomp/seccomp_bpf.c | 2 +- > >> 2 files changed, 27 insertions(+), 6 deletions(-) > > > > is there a dependency on this in patches 2+ ? > > if not, I would send this patch to selftests right away. > > > > > > The Landlock tests [patch 9/10] rely on it for now. > > I sent it three weeks ago: > https://lkml.kernel.org/r/20170806232337.4191-1-mic@digikod.net > > Anyway, until this patch is merged in the kselftest tree and then > available to net-next, I'll have to keep it here. Shuah, could you please pick up this patch into your tree?