Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752258AbdHZH5h convert rfc822-to-8bit (ORCPT ); Sat, 26 Aug 2017 03:57:37 -0400 Received: from bes.se.axis.com ([195.60.68.10]:46674 "EHLO bes.se.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750818AbdHZH5g (ORCPT ); Sat, 26 Aug 2017 03:57:36 -0400 From: Lars Persson To: Arnd Bergmann CC: Jesper Nilsson , Niklas Cassel , Herbert Xu , "David S. Miller" , linux-arm-kernel , "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] crypto: axis - hide an unused variable Thread-Topic: [PATCH] crypto: axis - hide an unused variable Thread-Index: AQHTHScyjiuIuI6FGkCZuNVTpctJLaKWR6MT Date: Sat, 26 Aug 2017 07:57:32 +0000 Message-ID: <1CCBE64C-1CA2-4F45-B7B0-E8D2363846B5@axis.com> References: <20170824222016.731342-1-arnd@arndb.de> In-Reply-To: <20170824222016.731342-1-arnd@arndb.de> Accept-Language: en-US Content-Language: sv-SE X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-TM-AS-GCONF: 00 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1422 Lines: 43 > 25 aug. 2017 kl. 01:20 skrev Arnd Bergmann : > > Without CONFIG_DEBUG_FS, we get a harmless warning: > > drivers/crypto/axis/artpec6_crypto.c:352:23: error: 'dbgfs_root' defined but not used [-Werror=unused-variable] > > This moves it into the #ifdef that hides the only user. > > Fixes: a21eb94fc4d3 ("crypto: axis - add ARTPEC-6/7 crypto accelerator driver") > Signed-off-by: Arnd Bergmann > --- > drivers/crypto/axis/artpec6_crypto.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/crypto/axis/artpec6_crypto.c b/drivers/crypto/axis/artpec6_crypto.c > index d9fbbf01062b..0f9754e07719 100644 > --- a/drivers/crypto/axis/artpec6_crypto.c > +++ b/drivers/crypto/axis/artpec6_crypto.c > @@ -349,8 +349,6 @@ struct artpec6_crypto_aead_req_ctx { > /* The crypto framework makes it hard to avoid this global. */ > static struct device *artpec6_crypto_dev; > > -static struct dentry *dbgfs_root; > - > #ifdef CONFIG_FAULT_INJECTION > static DECLARE_FAULT_ATTR(artpec6_crypto_fail_status_read); > static DECLARE_FAULT_ATTR(artpec6_crypto_fail_dma_array_full); > @@ -2984,6 +2982,8 @@ struct dbgfs_u32 { > char *desc; > }; > > +static struct dentry *dbgfs_root; > + > static void artpec6_crypto_init_debugfs(void) > { > dbgfs_root = debugfs_create_dir("artpec6_crypto", NULL); > -- > 2.9.0 Acked-by: Lars Persson Thanks, Lars