From: Heiko Stuebner <heiko@sntech.de>
To: Jagan Teki <jagannadh.teki@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Russell King <linux@armlinux.org.uk>,
        Michael Trimarchi <michael@amarulasolutions.com>,
        linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, Jagan Teki <jagan@amarulasolutions.com>
Subject: Re: [PATCH 2/2] ARM: dts: rockchip: Add rk3288 vyasa board
Date: Sat, 26 Aug 2017 11:52:21 +0200
Message-ID: <71627494.SRV9zSqJ5i@phil>
User-Agent: KMail/5.2.3 (Linux/4.11.0-1-amd64; KDE/5.28.0; x86_64; ; )
In-Reply-To: <1503730303-11422-2-git-send-email-jteki@openedev.com>
References: <1503730303-11422-1-git-send-email-jteki@openedev.com> <1503730303-11422-2-git-send-email-jteki@openedev.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 652
Lines: 21

Hi Jagan,

Am Samstag, 26. August 2017, 12:21:43 CEST schrieb Jagan Teki:
> From: Jagan Teki <jagan@amarulasolutions.com>
> 
> This patch adds initial support for rk3288 based
> Vyasa board, which is made by Amarula Solutions.
> 
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
>  arch/arm/boot/dts/Makefile         |   3 +-
>  arch/arm/boot/dts/rk3288-vyasa.dts | 312 +++++++++++++++++++++++++++++++++++++

please also add an entry for the board to
	Documentation/devicetree/bindings/arm/rockchip.txt

Otherwise looks good on first glance. I'll probably move some properties
myself to their alphabetical position when applying.


Heiko