Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751165AbdHZPJc (ORCPT ); Sat, 26 Aug 2017 11:09:32 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:48382 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751101AbdHZPJa (ORCPT ); Sat, 26 Aug 2017 11:09:30 -0400 Subject: Re: [patch V2 35/44] x86/idt: Switch early trap init to IDT tables To: Thomas Gleixner , Juergen Gross Cc: LKML , Ingo Molnar , Peter Anvin , Peter Zijlstra , Andy Lutomirski , Borislav Petkov , Steven Rostedt References: <20170825214648.264521964@linutronix.de> <20170825214942.983480384@linutronix.de> <7e182f46-d27b-9414-fb6d-ee48906a4180@oracle.com> From: Boris Ostrovsky Message-ID: <79d8e408-f51f-4dbd-68f3-16cdb95de2f8@oracle.com> Date: Sat, 26 Aug 2017 11:07:18 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 480 Lines: 20 On 08/26/2017 09:05 AM, Thomas Gleixner wrote: > > What occured to me right now, is that the patch removes: > > load_idt(&idt_descr); > > from the original function without adding it to the new one. Right, that's exactly what was broken for Xen. > So that needs > to be fixed, but not in the XEN code. It simply wants to be added to > idt_setup_early_traps(). I'll send out a V3 of that particular patch. Yes, that will work too (and keep original logic). -boris