Message-ID: <1503761195.12569.43.camel@perches.com>
Subject: Re: [PATCH] Staging rtlwifi efuse fix up a warning kzalloc
From: Joe Perches <joe@perches.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
        Yurii Pavlenko <pyldev@gmail.com>
Cc: gregkh@linuxfoundation.org, pkshih@realtek.com,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Date: Sat, 26 Aug 2017 08:26:35 -0700
In-Reply-To: <2ba8d35d-44e8-0509-469b-5564efe64e76@lwfinger.net>
References: <1503752478-9732-1-git-send-email-pyldev@gmail.com>
         <2ba8d35d-44e8-0509-469b-5564efe64e76@lwfinger.net>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 441
Lines: 14

On Sat, 2017-08-26 at 09:48 -0500, Larry Finger wrote:
> I will NACK every 
> patch that tries to force code that I maintain to use kcalloc over kzalloc.

Your choice.

The concept behind the kzalloc with multiply vs kcalloc
is protection against multiplication overflow.

It's unlikely to solve any real problem with a
sizeof(foo) * small known number of entries.

It does have application when number of entries is
a user specified value.