Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751124AbdHZRmF (ORCPT ); Sat, 26 Aug 2017 13:42:05 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:34010 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750737AbdHZRmE (ORCPT ); Sat, 26 Aug 2017 13:42:04 -0400 From: Arvind Yadav To: sjenning@redhat.com, ddstreet@ieee.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH] mm/zswap: constify struct kernel_param_ops uses Date: Sat, 26 Aug 2017 23:11:48 +0530 Message-Id: <2e26a2cef6e2148a7aadb77e9e64835fab6b4dc2.1503769223.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1739 Lines: 42 kernel_param_ops are not supposed to change at runtime. All functions working with kernel_param_ops provided by work with const kernel_param_ops. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- mm/zswap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/zswap.c b/mm/zswap.c index d39581a..030fbf9 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -82,7 +82,7 @@ static u64 zswap_duplicate_entry; static bool zswap_enabled; static int zswap_enabled_param_set(const char *, const struct kernel_param *); -static struct kernel_param_ops zswap_enabled_param_ops = { +static const struct kernel_param_ops zswap_enabled_param_ops = { .set = zswap_enabled_param_set, .get = param_get_bool, }; @@ -93,7 +93,7 @@ module_param_cb(enabled, &zswap_enabled_param_ops, &zswap_enabled, 0644); static char *zswap_compressor = ZSWAP_COMPRESSOR_DEFAULT; static int zswap_compressor_param_set(const char *, const struct kernel_param *); -static struct kernel_param_ops zswap_compressor_param_ops = { +static const struct kernel_param_ops zswap_compressor_param_ops = { .set = zswap_compressor_param_set, .get = param_get_charp, .free = param_free_charp, @@ -105,7 +105,7 @@ module_param_cb(compressor, &zswap_compressor_param_ops, #define ZSWAP_ZPOOL_DEFAULT "zbud" static char *zswap_zpool_type = ZSWAP_ZPOOL_DEFAULT; static int zswap_zpool_param_set(const char *, const struct kernel_param *); -static struct kernel_param_ops zswap_zpool_param_ops = { +static const struct kernel_param_ops zswap_zpool_param_ops = { .set = zswap_zpool_param_set, .get = param_get_charp, .free = param_free_charp, -- 2.7.4