Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751181AbdH0Btm (ORCPT ); Sat, 26 Aug 2017 21:49:42 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:36582 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751128AbdH0Btl (ORCPT ); Sat, 26 Aug 2017 21:49:41 -0400 Date: Sat, 26 Aug 2017 18:49:35 -0700 (PDT) Message-Id: <20170826.184935.212347255600368908.davem@davemloft.net> To: himanshujha199640@gmail.com Cc: herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] crypto: n2 - remove null check before kfree From: David Miller In-Reply-To: <1503782130-10137-2-git-send-email-himanshujha199640@gmail.com> References: <1503782130-10137-1-git-send-email-himanshujha199640@gmail.com> <1503782130-10137-2-git-send-email-himanshujha199640@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 26 Aug 2017 18:49:36 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 275 Lines: 8 From: Himanshu Jha Date: Sun, 27 Aug 2017 02:45:29 +0530 > kfree on NULL pointer is a no-op and therefore checking it is redundant. > > Signed-off-by: Himanshu Jha Acked-by: David S. Miller