Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751262AbdH0IRN (ORCPT ); Sun, 27 Aug 2017 04:17:13 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:20046 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750879AbdH0IRM (ORCPT ); Sun, 27 Aug 2017 04:17:12 -0400 Date: Sun, 27 Aug 2017 11:16:58 +0300 From: Yuval Shaia To: Himanshu Jha Cc: selvin.xavier@broadcom.com, devesh.sharma@broadcom.com, somnath.kotur@broadcom.com, dledford@redhat.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] RDMA/bnxt_re: remove unnecessary call to memset Message-ID: <20170827081657.GA5681@yuvallap> References: <1503677462-24238-1-git-send-email-himanshujha199640@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1503677462-24238-1-git-send-email-himanshujha199640@gmail.com> User-Agent: Mutt/1.8.3 (2017-05-23) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1318 Lines: 42 On Fri, Aug 25, 2017 at 09:41:02PM +0530, Himanshu Jha wrote: > call to memset to assign 0 value immediately after allocating > memory with kzalloc is unnecesaary as kzalloc allocates the memory > filled with 0 value. > > Signed-off-by: Himanshu Jha > --- > drivers/infiniband/hw/bnxt_re/ib_verbs.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c > index f0e01b3..fa6fbac 100644 > --- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c > +++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c > @@ -969,7 +969,6 @@ static struct bnxt_re_ah *bnxt_re_create_shadow_qp_ah > if (!ah) > return NULL; > > - memset(ah, 0, sizeof(*ah)); > ah->rdev = rdev; > ah->qplib_ah.pd = &pd->qplib_pd; > > @@ -1016,7 +1015,6 @@ static struct bnxt_re_qp *bnxt_re_create_shadow_qp > if (!qp) > return NULL; > > - memset(qp, 0, sizeof(*qp)); > qp->rdev = rdev; > > /* Initialize the shadow QP structure from the QP1 values */ > -- > 2.7.4 FWIW Reviewed-by: Yuval Shaia > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html