Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751269AbdH0L2y (ORCPT ); Sun, 27 Aug 2017 07:28:54 -0400 Received: from sysam.it ([5.39.81.93]:35296 "EHLO sysam.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751124AbdH0L2x (ORCPT ); Sun, 27 Aug 2017 07:28:53 -0400 X-Greylist: delayed 401 seconds by postgrey-1.27 at vger.kernel.org; Sun, 27 Aug 2017 07:28:53 EDT Subject: Re: [PATCH] m68knommu: remove dead code To: Alexandre Belloni , Greg Ungerer , Geert Uytterhoeven Cc: linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170824143407.21273-1-alexandre.belloni@free-electrons.com> From: Angelo Dureghello Organization: Sysam Message-ID: <363abb76-2001-f072-fd8e-332014ee07e0@sysam.it> Date: Sun, 27 Aug 2017 13:22:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170824143407.21273-1-alexandre.belloni@free-electrons.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1849 Lines: 66 Hi, just to inform you that i have in mind to add spi(soon, at least seems just a matter con Kconfig changes) and usdhc(later) drivers/support for stmark2 mcf5441x based board. But no problem, in case i'll re-add the this code as needed. On 24/08/2017 16:34, Alexandre Belloni wrote: > As CONFIG_RTC_DRV_M5441x doesn't exist because the driver never made it > upstream, there is no device to register. Remove code that is never > compiled and init_BSP() as it doesn't do anything. > > Signed-off-by: Alexandre Belloni > --- > arch/m68k/coldfire/m5441x.c | 37 ------------------------------------- > 1 file changed, 37 deletions(-) > > diff --git a/arch/m68k/coldfire/m5441x.c b/arch/m68k/coldfire/m5441x.c > index dc589b039b62..04fd7fde9fb3 100644 > --- a/arch/m68k/coldfire/m5441x.c > +++ b/arch/m68k/coldfire/m5441x.c > @@ -222,40 +222,3 @@ void __init config_BSP(char *commandp, int size) > m5441x_uarts_init(); > m5441x_fec_init(); > } > - > - > -#if IS_ENABLED(CONFIG_RTC_DRV_M5441x) > -static struct resource m5441x_rtc_resources[] = { > - { > - .start = MCFRTC_BASE, > - .end = MCFRTC_BASE + MCFRTC_SIZE - 1, > - .flags = IORESOURCE_MEM, > - }, > - { > - .start = MCF_IRQ_RTC, > - .end = MCF_IRQ_RTC, > - .flags = IORESOURCE_IRQ, > - }, > -}; > - > -static struct platform_device m5441x_rtc = { > - .name = "mcfrtc", > - .id = 0, > - .resource = m5441x_rtc_resources, > - .num_resources = ARRAY_SIZE(m5441x_rtc_resources), > -}; > -#endif > - > -static struct platform_device *m5441x_devices[] __initdata = { > -#if IS_ENABLED(CONFIG_RTC_DRV_M5441x) > - &m5441x_rtc, > -#endif > -}; > - > -static int __init init_BSP(void) > -{ > - platform_add_devices(m5441x_devices, ARRAY_SIZE(m5441x_devices)); > - return 0; > -} > - > -arch_initcall(init_BSP); > Regards, Angelo