Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751581AbdH0OCw (ORCPT ); Sun, 27 Aug 2017 10:02:52 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:32874 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751422AbdH0OCv (ORCPT ); Sun, 27 Aug 2017 10:02:51 -0400 Date: Sun, 27 Aug 2017 15:02:38 +0100 From: Mark Brown To: Ryan Lee Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, kuninori.morimoto.gx@renesas.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, ryan.lee.maxim@gmail.com Subject: Re: [PATCH 1/9] ASoC: max98927: Added TDM support Message-ID: <20170827140238.bqav6pkpxd2yogch@sirena.org.uk> References: <1503708070-7906-1-git-send-email-ryans.lee@maximintegrated.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ozghonnujalcj4qi" Content-Disposition: inline In-Reply-To: <1503708070-7906-1-git-send-email-ryans.lee@maximintegrated.com> X-Cookie: Often things ARE as bad as they seem! User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1316 Lines: 41 --ozghonnujalcj4qi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Aug 25, 2017 at 05:41:02PM -0700, Ryan Lee wrote: > Signed-off-by: Ryan Lee This says it's adding support for TDM mode but... > + case SND_SOC_DAIFMT_DSP_A: > + format = MAX98927_PCM_FORMAT_TDM_MODE1; > + break; > + case SND_SOC_DAIFMT_DSP_B: > + format = MAX98927_PCM_FORMAT_TDM_MODE0; > + break; > case SND_SOC_DAIFMT_PDM: > - max98927->iface |= SND_SOC_DAIFMT_PDM; > + use_pdm = true; > break; ...it looks like it's adding support for two new DSP modes and generally making a bunch of other changes. This probably needs splitting up, or at least a bit more of a changelog. --ozghonnujalcj4qi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlmi0PkACgkQJNaLcl1U h9CmQQf+Mdba/LEwNXEp60e9gowmM0eWXqYV72DTD/LDevnesYy/JcgrAh0zZuE8 TaXfzw9wkccvgxu6Tf5VBxyngoidm2kl9NKg38S/WWGCdsRqygqBsvVmzWK/MjaF Mfaz0yZ4hvEkmuHN6Dr++Fl69zfKsln/cDus1EJ4aigO4wDl6RQzRifvnLRjRI8w ebfeg+f71Yjz8uJWD38ZP+tcxu/3lwbIyuri9xBJHcN12RTgv/OijmzYwl1s+CgD gAgfmG7DLQIrCnU2xiieMXS1XYr7/VqU4+C1ZQTRV9ZKIzHLDmgusp28msY8Kqni XjnSVJP0D+wB9xKpPl6L0fWxfc+r2A== =9xtP -----END PGP SIGNATURE----- --ozghonnujalcj4qi--