Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751218AbdH0PRR (ORCPT ); Sun, 27 Aug 2017 11:17:17 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:55722 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751162AbdH0PRP (ORCPT ); Sun, 27 Aug 2017 11:17:15 -0400 Date: Sun, 27 Aug 2017 12:17:03 -0300 From: Mauro Carvalho Chehab To: Cc: , , , , , Masayuki Yamamoto , Hideki Nozawa , "Kota Yonezawa" , Toshihiko Matsumoto , Satoshi Watanabe Subject: Re: [PATCH v3 08/14] [media] cxd2880: Add DVB-T control functions the driver Message-ID: <20170827121703.0400e6bb@vento.lan> In-Reply-To: <20170816044037.21539-1-Yasunari.Takiguchi@sony.com> References: <20170816041714.20551-1-Yasunari.Takiguchi@sony.com> <20170816044037.21539-1-Yasunari.Takiguchi@sony.com> Organization: Samsung X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 34406 Lines: 1349 Em Wed, 16 Aug 2017 13:40:37 +0900 escreveu: > From: Yasunari Takiguchi > > Provide definitions, interfaces and functions needed for DVB-T > of the Sony CXD2880 DVB-T2/T tuner + demodulator driver. > > [Change list] > Changes in V3 > drivers/media/dvb-frontends/cxd2880/cxd2880_dvbt.h > -no change > drivers/media/dvb-frontends/cxd2880/cxd2880_tnrdmd_dvbt.c > -modified return code > -modified coding style of if() > -changed hexadecimal code to lower case. > drivers/media/dvb-frontends/cxd2880/cxd2880_tnrdmd_dvbt.h > -modified return code > > Signed-off-by: Yasunari Takiguchi > Signed-off-by: Masayuki Yamamoto > Signed-off-by: Hideki Nozawa > Signed-off-by: Kota Yonezawa > Signed-off-by: Toshihiko Matsumoto > Signed-off-by: Satoshi Watanabe > --- > drivers/media/dvb-frontends/cxd2880/cxd2880_dvbt.h | 91 ++ > .../dvb-frontends/cxd2880/cxd2880_tnrdmd_dvbt.c | 1115 ++++++++++++++++++++ > .../dvb-frontends/cxd2880/cxd2880_tnrdmd_dvbt.h | 62 ++ > 3 files changed, 1268 insertions(+) > create mode 100644 drivers/media/dvb-frontends/cxd2880/cxd2880_dvbt.h > create mode 100644 drivers/media/dvb-frontends/cxd2880/cxd2880_tnrdmd_dvbt.c > create mode 100644 drivers/media/dvb-frontends/cxd2880/cxd2880_tnrdmd_dvbt.h > > diff --git a/drivers/media/dvb-frontends/cxd2880/cxd2880_dvbt.h b/drivers/media/dvb-frontends/cxd2880/cxd2880_dvbt.h > new file mode 100644 > index 000000000000..345c094760d2 > --- /dev/null > +++ b/drivers/media/dvb-frontends/cxd2880/cxd2880_dvbt.h > @@ -0,0 +1,91 @@ > +/* > + * cxd2880_dvbt.h > + * Sony CXD2880 DVB-T2/T tuner + demodulator driver > + * DVB-T related definitions > + * > + * Copyright (C) 2016, 2017 Sony Semiconductor Solutions Corporation > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms of the GNU General Public License as published by the > + * Free Software Foundation; version 2 of the License. > + * > + * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESS OR IMPLIED > + * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF > + * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN > + * NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, > + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT > + * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF > + * USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON > + * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF > + * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > + * > + * You should have received a copy of the GNU General Public License along > + * with this program; if not, see . > + */ > + > +#ifndef CXD2880_DVBT_H > +#define CXD2880_DVBT_H > + > +#include "cxd2880_common.h" > + > +enum cxd2880_dvbt_constellation { > + CXD2880_DVBT_CONSTELLATION_QPSK, > + CXD2880_DVBT_CONSTELLATION_16QAM, > + CXD2880_DVBT_CONSTELLATION_64QAM, > + CXD2880_DVBT_CONSTELLATION_RESERVED_3 > +}; > + > +enum cxd2880_dvbt_hierarchy { > + CXD2880_DVBT_HIERARCHY_NON, > + CXD2880_DVBT_HIERARCHY_1, > + CXD2880_DVBT_HIERARCHY_2, > + CXD2880_DVBT_HIERARCHY_4 > +}; > + > +enum cxd2880_dvbt_coderate { > + CXD2880_DVBT_CODERATE_1_2, > + CXD2880_DVBT_CODERATE_2_3, > + CXD2880_DVBT_CODERATE_3_4, > + CXD2880_DVBT_CODERATE_5_6, > + CXD2880_DVBT_CODERATE_7_8, > + CXD2880_DVBT_CODERATE_RESERVED_5, > + CXD2880_DVBT_CODERATE_RESERVED_6, > + CXD2880_DVBT_CODERATE_RESERVED_7 > +}; > + > +enum cxd2880_dvbt_guard { > + CXD2880_DVBT_GUARD_1_32, > + CXD2880_DVBT_GUARD_1_16, > + CXD2880_DVBT_GUARD_1_8, > + CXD2880_DVBT_GUARD_1_4 > +}; > + > +enum cxd2880_dvbt_mode { > + CXD2880_DVBT_MODE_2K, > + CXD2880_DVBT_MODE_8K, > + CXD2880_DVBT_MODE_RESERVED_2, > + CXD2880_DVBT_MODE_RESERVED_3 > +}; > + > +enum cxd2880_dvbt_profile { > + CXD2880_DVBT_PROFILE_HP = 0, > + CXD2880_DVBT_PROFILE_LP > +}; > + > +struct cxd2880_dvbt_tpsinfo { > + enum cxd2880_dvbt_constellation constellation; > + enum cxd2880_dvbt_hierarchy hierarchy; > + enum cxd2880_dvbt_coderate rate_hp; > + enum cxd2880_dvbt_coderate rate_lp; > + enum cxd2880_dvbt_guard guard; > + enum cxd2880_dvbt_mode mode; > + u8 fnum; > + u8 length_indicator; > + u16 cell_id; > + u8 cell_id_ok; > + u8 reserved_even; > + u8 reserved_odd; > +}; > + > +#endif > diff --git a/drivers/media/dvb-frontends/cxd2880/cxd2880_tnrdmd_dvbt.c b/drivers/media/dvb-frontends/cxd2880/cxd2880_tnrdmd_dvbt.c > new file mode 100644 > index 000000000000..8a16cb359171 > --- /dev/null > +++ b/drivers/media/dvb-frontends/cxd2880/cxd2880_tnrdmd_dvbt.c > @@ -0,0 +1,1115 @@ > +/* > + * cxd2880_tnrdmd_dvbt.c > + * Sony CXD2880 DVB-T2/T tuner + demodulator driver > + * control functions for DVB-T > + * > + * Copyright (C) 2016, 2017 Sony Semiconductor Solutions Corporation > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms of the GNU General Public License as published by the > + * Free Software Foundation; version 2 of the License. > + * > + * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESS OR IMPLIED > + * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF > + * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN > + * NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, > + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT > + * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF > + * USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON > + * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF > + * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > + * > + * You should have received a copy of the GNU General Public License along > + * with this program; if not, see . > + */ > + > +#include "cxd2880_tnrdmd_dvbt.h" > +#include "cxd2880_tnrdmd_dvbt_mon.h" > + > +static int x_tune_dvbt_demod_setting(struct cxd2880_tnrdmd > + *tnr_dmd, > + enum cxd2880_dtv_bandwidth > + bandwidth, > + enum cxd2880_tnrdmd_clockmode > + clk_mode) > +{ > + int ret = 0; > + > + if (!tnr_dmd) > + return -EINVAL; > + > + ret = tnr_dmd->io->write_reg(tnr_dmd->io, > + CXD2880_IO_TGT_SYS, > + 0x00, 0x00); > + if (ret) > + return ret; > + > + ret = tnr_dmd->io->write_reg(tnr_dmd->io, > + CXD2880_IO_TGT_SYS, > + 0x31, 0x01); > + if (ret) > + return ret; > + > + { > + u8 data_a[2] = { 0x52, 0x49 }; > + u8 data_b[2] = { 0x5d, 0x55 }; > + u8 data_c[2] = { 0x60, 0x00 }; Always declare immutable data as "static const". Same note I did before about using a code block here just to declare new data applies here and on other parts of this code. > + u8 *data = NULL; > + > + ret = tnr_dmd->io->write_reg(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x00, 0x04); > + if (ret) > + return ret; > + > + switch (clk_mode) { > + case CXD2880_TNRDMD_CLOCKMODE_A: > + data = data_a; > + break; > + case CXD2880_TNRDMD_CLOCKMODE_B: > + data = data_b; > + break; > + case CXD2880_TNRDMD_CLOCKMODE_C: > + data = data_c; > + break; > + default: > + return -EPERM; > + } > + > + ret = tnr_dmd->io->write_regs(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x65, data, 2); > + if (ret) > + return ret; > + } > + > + ret = tnr_dmd->io->write_reg(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x5d, 0x07); > + if (ret) > + return ret; > + > + if (tnr_dmd->diver_mode != CXD2880_TNRDMD_DIVERMODE_SUB) { > + u8 data[2] = { 0x01, 0x01 }; > + > + ret = tnr_dmd->io->write_reg(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x00, 0x00); > + if (ret) > + return ret; > + > + ret = tnr_dmd->io->write_regs(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0xce, data, 2); > + if (ret) > + return ret; > + } > + > + ret = tnr_dmd->io->write_reg(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x00, 0x04); > + if (ret) > + return ret; > + > + ret = tnr_dmd->io->write_reg(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x5c, 0xfb); > + if (ret) > + return ret; > + > + ret = tnr_dmd->io->write_reg(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x00, 0x10); > + if (ret) > + return ret; > + > + ret = tnr_dmd->io->write_reg(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0xa4, 0x03); > + if (ret) > + return ret; > + > + ret = tnr_dmd->io->write_reg(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x00, 0x14); > + if (ret) > + return ret; > + > + ret = tnr_dmd->io->write_reg(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0xb0, 0x00); > + if (ret) > + return ret; > + > + ret = tnr_dmd->io->write_reg(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x00, 0x25); > + if (ret) > + return ret; > + > + { > + u8 data[2] = { 0x01, 0xf0 }; > + > + ret = tnr_dmd->io->write_regs(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0xf0, data, 2); > + if (ret) > + return ret; > + } > + > + if ((tnr_dmd->diver_mode == CXD2880_TNRDMD_DIVERMODE_MAIN) || > + (tnr_dmd->diver_mode == CXD2880_TNRDMD_DIVERMODE_SUB)) { > + ret = tnr_dmd->io->write_reg(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x00, 0x12); > + if (ret) > + return ret; > + > + ret = tnr_dmd->io->write_reg(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x44, 0x00); > + if (ret) > + return ret; > + } > + > + if (tnr_dmd->diver_mode == CXD2880_TNRDMD_DIVERMODE_SUB) { > + ret = tnr_dmd->io->write_reg(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x00, 0x11); > + if (ret) > + return ret; > + > + ret = tnr_dmd->io->write_reg(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x87, 0xd2); > + if (ret) > + return ret; > + } > + > + if (tnr_dmd->diver_mode != CXD2880_TNRDMD_DIVERMODE_SUB) { > + u8 data_a[3] = { 0x73, 0xca, 0x49 }; > + u8 data_b[3] = { 0xc8, 0x13, 0xaa }; > + u8 data_c[3] = { 0xdc, 0x6c, 0x00 }; const? > + u8 *data = NULL; > + > + ret = tnr_dmd->io->write_reg(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x00, 0x04); > + if (ret) > + return ret; > + > + switch (clk_mode) { > + case CXD2880_TNRDMD_CLOCKMODE_A: > + data = data_a; > + break; > + case CXD2880_TNRDMD_CLOCKMODE_B: > + data = data_b; > + break; > + case CXD2880_TNRDMD_CLOCKMODE_C: > + data = data_c; > + break; > + default: > + return -EPERM; > + } > + > + ret = tnr_dmd->io->write_regs(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x68, data, 3); > + if (ret) > + return ret; > + } > + > + ret = tnr_dmd->io->write_reg(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x00, 0x04); > + if (ret) > + return ret; > + > + switch (bandwidth) { > + case CXD2880_DTV_BW_8_MHZ: > + > + { > + u8 data_ac[5] = { 0x15, 0x00, 0x00, 0x00, > + 0x00 > + }; > + u8 data_b[5] = { 0x14, 0x6a, 0xaa, 0xaa, > + 0xaa > + }; const? > + u8 *data = NULL; > + > + switch (clk_mode) { > + case CXD2880_TNRDMD_CLOCKMODE_A: > + case CXD2880_TNRDMD_CLOCKMODE_C: > + data = data_ac; > + break; > + case CXD2880_TNRDMD_CLOCKMODE_B: > + data = data_b; > + break; > + default: > + return -EPERM; > + } > + > + ret = tnr_dmd->io->write_regs(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x60, data, 5); > + if (ret) > + return ret; > + } > + > + ret = tnr_dmd->io->write_reg(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x4a, 0x00); > + if (ret) > + return ret; > + > + { > + u8 data_a[2] = { 0x01, 0x28 }; > + u8 data_b[2] = { 0x11, 0x44 }; > + u8 data_c[2] = { 0x15, 0x28 }; const? > + u8 *data = NULL; > + > + switch (clk_mode) { > + case CXD2880_TNRDMD_CLOCKMODE_A: > + data = data_a; > + break; > + case CXD2880_TNRDMD_CLOCKMODE_B: > + data = data_b; > + break; > + case CXD2880_TNRDMD_CLOCKMODE_C: > + data = data_c; > + break; > + default: > + return -EPERM; > + } > + > + ret = tnr_dmd->io->write_regs(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x7d, data, 2); > + if (ret) > + return ret; > + } > + > + { > + u8 data = 0; > + > + switch (clk_mode) { > + case CXD2880_TNRDMD_CLOCKMODE_A: > + case CXD2880_TNRDMD_CLOCKMODE_B: > + data = 0x35; > + break; > + case CXD2880_TNRDMD_CLOCKMODE_C: > + data = 0x34; > + break; > + default: > + return -EPERM; > + } > + > + ret = tnr_dmd->io->write_reg(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x71, data); > + if (ret) > + return ret; > + } > + > + if (tnr_dmd->diver_mode == CXD2880_TNRDMD_DIVERMODE_MAIN) { > + u8 data_a[5] = { 0x30, 0x00, 0x00, 0x90, > + 0x00 > + }; > + u8 data_b[5] = { 0x36, 0x71, 0x00, 0xa3, > + 0x55 > + }; > + u8 data_c[5] = { 0x38, 0x00, 0x00, 0xa8, > + 0x00 > + }; const? > + u8 *data = NULL; > + > + switch (clk_mode) { > + case CXD2880_TNRDMD_CLOCKMODE_A: > + data = data_a; > + break; > + case CXD2880_TNRDMD_CLOCKMODE_B: > + data = data_b; > + break; > + case CXD2880_TNRDMD_CLOCKMODE_C: > + data = data_c; > + break; > + default: > + return -EPERM; > + } > + > + ret = tnr_dmd->io->write_regs(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x4b, &data[0], 2); > + if (ret) > + return ret; > + > + ret = tnr_dmd->io->write_regs(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x51, &data[2], 3); > + if (ret) > + return ret; > + } > + > + { > + u8 data[4] = { 0xb3, 0x00, 0x01, 0x02 }; > + > + ret = tnr_dmd->io->write_regs(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x72, &data[0], 2); > + if (ret) > + return ret; > + > + ret = tnr_dmd->io->write_regs(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x6b, &data[2], 2); > + if (ret) > + return ret; > + } > + break; > + > + case CXD2880_DTV_BW_7_MHZ: > + > + { > + u8 data_ac[5] = { 0x18, 0x00, 0x00, 0x00, > + 0x00 > + }; > + u8 data_b[5] = { 0x17, 0x55, 0x55, 0x55, > + 0x55 > + }; const? > + u8 *data = NULL; > + > + switch (clk_mode) { > + case CXD2880_TNRDMD_CLOCKMODE_A: > + case CXD2880_TNRDMD_CLOCKMODE_C: > + data = data_ac; > + break; > + case CXD2880_TNRDMD_CLOCKMODE_B: > + data = data_b; > + break; > + default: > + return -EPERM; > + } > + > + ret = tnr_dmd->io->write_regs(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x60, data, 5); > + if (ret) > + return ret; > + } > + > + ret = tnr_dmd->io->write_reg(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x4a, 0x02); > + if (ret) > + return ret; > + > + { > + u8 data_a[2] = { 0x12, 0x4c }; > + u8 data_b[2] = { 0x1f, 0x15 }; > + u8 data_c[2] = { 0x1f, 0xf8 }; const? (will stop pinpoint those static const data) > + u8 *data = NULL; > + > + switch (clk_mode) { > + case CXD2880_TNRDMD_CLOCKMODE_A: > + data = data_a; > + break; > + case CXD2880_TNRDMD_CLOCKMODE_B: > + data = data_b; > + break; > + case CXD2880_TNRDMD_CLOCKMODE_C: > + data = data_c; > + break; > + default: > + return -EPERM; > + } > + > + ret = tnr_dmd->io->write_regs(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x7d, data, 2); > + if (ret) > + return ret; > + } > + > + { > + u8 data = 0; > + > + switch (clk_mode) { > + case CXD2880_TNRDMD_CLOCKMODE_A: > + case CXD2880_TNRDMD_CLOCKMODE_B: > + data = 0x2f; > + break; > + case CXD2880_TNRDMD_CLOCKMODE_C: > + data = 0x2e; > + break; > + default: > + return -EPERM; > + } > + > + ret = tnr_dmd->io->write_reg(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x71, data); > + if (ret) > + return ret; > + } > + > + if (tnr_dmd->diver_mode == CXD2880_TNRDMD_DIVERMODE_MAIN) { > + u8 data_a[5] = { 0x36, 0xdb, 0x00, 0xa4, > + 0x92 > + }; > + u8 data_b[5] = { 0x3e, 0x38, 0x00, 0xba, > + 0xaa > + }; > + u8 data_c[5] = { 0x40, 0x00, 0x00, 0xc0, > + 0x00 > + }; > + u8 *data = NULL; > + > + switch (clk_mode) { > + case CXD2880_TNRDMD_CLOCKMODE_A: > + data = data_a; > + break; > + case CXD2880_TNRDMD_CLOCKMODE_B: > + data = data_b; > + break; > + case CXD2880_TNRDMD_CLOCKMODE_C: > + data = data_c; > + break; > + default: > + return -EPERM; > + } > + > + ret = tnr_dmd->io->write_regs(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x4b, &data[0], 2); > + if (ret) > + return ret; > + > + ret = tnr_dmd->io->write_regs(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x51, &data[2], 3); > + if (ret) > + return ret; > + } > + > + { > + u8 data[4] = { 0xb8, 0x00, 0x00, 0x03 }; > + > + ret = tnr_dmd->io->write_regs(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x72, &data[0], 2); > + if (ret) > + return ret; > + > + ret = tnr_dmd->io->write_regs(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x6b, &data[2], 2); > + if (ret) > + return ret; > + } > + break; > + > + case CXD2880_DTV_BW_6_MHZ: > + > + { > + u8 data_ac[5] = { 0x1c, 0x00, 0x00, 0x00, > + 0x00 > + }; > + u8 data_b[5] = { 0x1b, 0x38, 0xe3, 0x8e, > + 0x38 > + }; > + u8 *data = NULL; > + > + switch (clk_mode) { > + case CXD2880_TNRDMD_CLOCKMODE_A: > + case CXD2880_TNRDMD_CLOCKMODE_C: > + data = data_ac; > + break; > + case CXD2880_TNRDMD_CLOCKMODE_B: > + data = data_b; > + break; > + default: > + return -EPERM; > + } > + > + ret = tnr_dmd->io->write_regs(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x60, data, 5); > + if (ret) > + return ret; > + } > + > + ret = tnr_dmd->io->write_reg(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x4a, 0x04); > + if (ret) > + return ret; > + > + { > + u8 data_a[2] = { 0x1f, 0xf8 }; > + u8 data_b[2] = { 0x24, 0x43 }; > + u8 data_c[2] = { 0x25, 0x4c }; > + u8 *data = NULL; > + > + switch (clk_mode) { > + case CXD2880_TNRDMD_CLOCKMODE_A: > + data = data_a; > + break; > + case CXD2880_TNRDMD_CLOCKMODE_B: > + data = data_b; > + break; > + case CXD2880_TNRDMD_CLOCKMODE_C: > + data = data_c; > + break; > + default: > + return -EPERM; > + } > + > + ret = tnr_dmd->io->write_regs(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x7d, data, 2); > + if (ret) > + return ret; > + } > + > + { > + u8 data = 0; > + > + switch (clk_mode) { > + case CXD2880_TNRDMD_CLOCKMODE_A: > + case CXD2880_TNRDMD_CLOCKMODE_C: > + data = 0x29; > + break; > + case CXD2880_TNRDMD_CLOCKMODE_B: > + data = 0x2a; > + break; > + default: > + return -EPERM; > + } > + > + ret = tnr_dmd->io->write_reg(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x71, data); > + if (ret) > + return ret; > + } > + > + if (tnr_dmd->diver_mode == CXD2880_TNRDMD_DIVERMODE_MAIN) { > + u8 data_a[5] = { 0x40, 0x00, 0x00, 0xc0, > + 0x00 > + }; > + u8 data_b[5] = { 0x48, 0x97, 0x00, 0xd9, > + 0xc7 > + }; > + u8 data_c[5] = { 0x4a, 0xaa, 0x00, 0xdf, > + 0xff > + }; > + u8 *data = NULL; > + > + switch (clk_mode) { > + case CXD2880_TNRDMD_CLOCKMODE_A: > + data = data_a; > + break; > + case CXD2880_TNRDMD_CLOCKMODE_B: > + data = data_b; > + break; > + case CXD2880_TNRDMD_CLOCKMODE_C: > + data = data_c; > + break; > + default: > + return -EPERM; > + } > + > + ret = tnr_dmd->io->write_regs(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x4b, &data[0], 2); > + if (ret) > + return ret; > + > + ret = tnr_dmd->io->write_regs(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x51, &data[2], 3); > + if (ret) > + return ret; > + } > + > + { > + u8 data[4] = { 0xbe, 0xab, 0x00, 0x03 }; > + > + ret = tnr_dmd->io->write_regs(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x72, &data[0], 2); > + if (ret) > + return ret; > + > + ret = tnr_dmd->io->write_regs(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x6b, &data[2], 2); > + if (ret) > + return ret; > + } > + break; > + > + case CXD2880_DTV_BW_5_MHZ: > + > + { > + u8 data_ac[5] = { 0x21, 0x99, 0x99, 0x99, > + 0x99 > + }; > + u8 data_b[5] = { 0x20, 0xaa, 0xaa, 0xaa, > + 0xaa > + }; > + u8 *data = NULL; > + > + switch (clk_mode) { > + case CXD2880_TNRDMD_CLOCKMODE_A: > + case CXD2880_TNRDMD_CLOCKMODE_C: > + data = data_ac; > + break; > + case CXD2880_TNRDMD_CLOCKMODE_B: > + data = data_b; > + break; > + default: > + return -EPERM; > + } > + > + ret = tnr_dmd->io->write_regs(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x60, data, 5); > + if (ret) > + return ret; > + } > + > + ret = tnr_dmd->io->write_reg(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x4a, 0x06); > + if (ret) > + return ret; > + > + { > + u8 data_a[2] = { 0x26, 0x5d }; > + u8 data_b[2] = { 0x2b, 0x84 }; > + u8 data_c[2] = { 0x2c, 0xc2 }; > + u8 *data = NULL; > + > + switch (clk_mode) { > + case CXD2880_TNRDMD_CLOCKMODE_A: > + data = data_a; > + break; > + case CXD2880_TNRDMD_CLOCKMODE_B: > + data = data_b; > + break; > + case CXD2880_TNRDMD_CLOCKMODE_C: > + data = data_c; > + break; > + default: > + return -EPERM; > + } > + > + ret = tnr_dmd->io->write_regs(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x7d, data, 2); > + if (ret) > + return ret; > + } > + > + { > + u8 data = 0; > + > + switch (clk_mode) { > + case CXD2880_TNRDMD_CLOCKMODE_A: > + case CXD2880_TNRDMD_CLOCKMODE_B: > + data = 0x24; > + break; > + case CXD2880_TNRDMD_CLOCKMODE_C: > + data = 0x23; > + break; > + default: > + return -EPERM; > + } > + > + ret = tnr_dmd->io->write_reg(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x71, data); > + if (ret) > + return ret; > + } > + > + if (tnr_dmd->diver_mode == CXD2880_TNRDMD_DIVERMODE_MAIN) { > + u8 data_a[5] = { 0x4c, 0xcc, 0x00, 0xe6, > + 0x66 > + }; > + u8 data_b[5] = { 0x57, 0x1c, 0x01, 0x05, > + 0x55 > + }; > + u8 data_c[5] = { 0x59, 0x99, 0x01, 0x0c, > + 0xcc > + }; > + u8 *data = NULL; > + > + switch (clk_mode) { > + case CXD2880_TNRDMD_CLOCKMODE_A: > + data = data_a; > + break; > + case CXD2880_TNRDMD_CLOCKMODE_B: > + data = data_b; > + break; > + case CXD2880_TNRDMD_CLOCKMODE_C: > + data = data_c; > + break; > + default: > + return -EPERM; > + } > + > + ret = tnr_dmd->io->write_regs(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x4b, &data[0], 2); > + if (ret) > + return ret; > + > + ret = tnr_dmd->io->write_regs(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x51, &data[2], 3); > + if (ret) > + return ret; > + } > + > + { > + u8 data[4] = { 0xc8, 0x01, 0x00, 0x03 }; > + > + ret = tnr_dmd->io->write_regs(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x72, &data[0], 2); > + if (ret) > + return ret; > + > + ret = tnr_dmd->io->write_regs(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x6b, &data[2], 2); > + if (ret) > + return ret; > + } > + break; > + > + default: > + return -EPERM; > + } > + > + ret = tnr_dmd->io->write_reg(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x00, 0x00); > + if (ret) > + return ret; > + > + ret = tnr_dmd->io->write_reg(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0xfd, 0x01); > + if (ret) > + return ret; > + > + return 0; > +} > + > +static int x_sleep_dvbt_demod_setting(struct cxd2880_tnrdmd > + *tnr_dmd) > +{ > + int ret = 0; > + > + if (!tnr_dmd) > + return -EINVAL; > + > + ret = tnr_dmd->io->write_reg(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x00, 0x04); > + if (ret) > + return ret; > + > + ret = tnr_dmd->io->write_reg(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x5c, 0xd8); > + if (ret) > + return ret; > + > + ret = tnr_dmd->io->write_reg(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x00, 0x10); > + if (ret) > + return ret; > + > + ret = tnr_dmd->io->write_reg(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0xa4, 0x00); > + if (ret) > + return ret; > + > + if (tnr_dmd->diver_mode == CXD2880_TNRDMD_DIVERMODE_SUB) { > + ret = tnr_dmd->io->write_reg(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x00, 0x11); > + if (ret) > + return ret; > + > + ret = tnr_dmd->io->write_reg(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x87, 0x04); > + if (ret) > + return ret; > + } > + > + return 0; > +} > + > +static int dvbt_set_profile(struct cxd2880_tnrdmd *tnr_dmd, > + enum cxd2880_dvbt_profile profile) > +{ > + int ret = 0; > + > + if (!tnr_dmd) > + return -EINVAL; > + > + ret = tnr_dmd->io->write_reg(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x00, 0x10); > + if (ret) > + return ret; > + > + ret = tnr_dmd->io->write_reg(tnr_dmd->io, > + CXD2880_IO_TGT_DMD, > + 0x67, > + (profile == CXD2880_DVBT_PROFILE_HP) > + ? 0x00 : 0x01); > + if (ret) > + return ret; > + > + return ret; > +} > + > +int cxd2880_tnrdmd_dvbt_tune1(struct cxd2880_tnrdmd *tnr_dmd, > + struct cxd2880_dvbt_tune_param > + *tune_param) > +{ > + int ret = 0; > + > + if ((!tnr_dmd) || (!tune_param)) > + return -EINVAL; > + > + if (tnr_dmd->diver_mode == CXD2880_TNRDMD_DIVERMODE_SUB) > + return -EINVAL; > + > + if ((tnr_dmd->state != CXD2880_TNRDMD_STATE_SLEEP) && > + (tnr_dmd->state != CXD2880_TNRDMD_STATE_ACTIVE)) > + return -EPERM; > + > + ret = > + cxd2880_tnrdmd_common_tune_setting1(tnr_dmd, CXD2880_DTV_SYS_DVBT, > + tune_param->center_freq_khz, > + tune_param->bandwidth, 0, 0); > + if (ret) > + return ret; > + > + ret = > + x_tune_dvbt_demod_setting(tnr_dmd, tune_param->bandwidth, > + tnr_dmd->clk_mode); > + if (ret) > + return ret; > + > + if (tnr_dmd->diver_mode == CXD2880_TNRDMD_DIVERMODE_MAIN) { > + ret = > + x_tune_dvbt_demod_setting(tnr_dmd->diver_sub, > + tune_param->bandwidth, > + tnr_dmd->diver_sub->clk_mode); > + if (ret) > + return ret; > + } > + > + ret = dvbt_set_profile(tnr_dmd, tune_param->profile); > + if (ret) > + return ret; > + > + return 0; > +} > + > +int cxd2880_tnrdmd_dvbt_tune2(struct cxd2880_tnrdmd *tnr_dmd, > + struct cxd2880_dvbt_tune_param > + *tune_param) > +{ > + int ret = 0; > + > + if ((!tnr_dmd) || (!tune_param)) > + return -EINVAL; > + > + if (tnr_dmd->diver_mode == CXD2880_TNRDMD_DIVERMODE_SUB) > + return -EINVAL; > + > + if ((tnr_dmd->state != CXD2880_TNRDMD_STATE_SLEEP) && > + (tnr_dmd->state != CXD2880_TNRDMD_STATE_ACTIVE)) > + return -EPERM; > + > + ret = > + cxd2880_tnrdmd_common_tune_setting2(tnr_dmd, CXD2880_DTV_SYS_DVBT, > + 0); > + if (ret) > + return ret; > + > + tnr_dmd->state = CXD2880_TNRDMD_STATE_ACTIVE; > + tnr_dmd->frequency_khz = tune_param->center_freq_khz; > + tnr_dmd->sys = CXD2880_DTV_SYS_DVBT; > + tnr_dmd->bandwidth = tune_param->bandwidth; > + > + if (tnr_dmd->diver_mode == CXD2880_TNRDMD_DIVERMODE_MAIN) { > + tnr_dmd->diver_sub->state = CXD2880_TNRDMD_STATE_ACTIVE; > + tnr_dmd->diver_sub->frequency_khz = tune_param->center_freq_khz; > + tnr_dmd->diver_sub->sys = CXD2880_DTV_SYS_DVBT; > + tnr_dmd->diver_sub->bandwidth = tune_param->bandwidth; > + } > + > + return 0; > +} > + > +int cxd2880_tnrdmd_dvbt_sleep_setting(struct cxd2880_tnrdmd *tnr_dmd) > +{ > + int ret = 0; > + > + if (!tnr_dmd) > + return -EINVAL; > + > + if (tnr_dmd->diver_mode == CXD2880_TNRDMD_DIVERMODE_SUB) > + return -EINVAL; > + > + if ((tnr_dmd->state != CXD2880_TNRDMD_STATE_SLEEP) && > + (tnr_dmd->state != CXD2880_TNRDMD_STATE_ACTIVE)) > + return -EPERM; > + > + ret = x_sleep_dvbt_demod_setting(tnr_dmd); > + if (ret) > + return ret; > + > + if (tnr_dmd->diver_mode == CXD2880_TNRDMD_DIVERMODE_MAIN) { > + ret = x_sleep_dvbt_demod_setting(tnr_dmd->diver_sub); > + if (ret) > + return ret; > + } > + > + return 0; > +} > + > +int cxd2880_tnrdmd_dvbt_check_demod_lock(struct cxd2880_tnrdmd > + *tnr_dmd, > + enum > + cxd2880_tnrdmd_lock_result > + *lock) > +{ > + int ret = 0; > + > + u8 sync_stat = 0; > + u8 ts_lock = 0; > + u8 unlock_detected = 0; > + u8 unlock_detected_sub = 0; > + > + if ((!tnr_dmd) || (!lock)) > + return -EINVAL; > + > + if (tnr_dmd->diver_mode == CXD2880_TNRDMD_DIVERMODE_SUB) > + return -EINVAL; > + > + if (tnr_dmd->state != CXD2880_TNRDMD_STATE_ACTIVE) > + return -EPERM; > + > + ret = > + cxd2880_tnrdmd_dvbt_mon_sync_stat(tnr_dmd, &sync_stat, &ts_lock, > + &unlock_detected); > + if (ret) > + return ret; > + > + if (tnr_dmd->diver_mode == CXD2880_TNRDMD_DIVERMODE_SINGLE) { > + if (sync_stat == 6) > + *lock = CXD2880_TNRDMD_LOCK_RESULT_LOCKED; > + else if (unlock_detected) > + *lock = CXD2880_TNRDMD_LOCK_RESULT_UNLOCKED; > + else > + *lock = CXD2880_TNRDMD_LOCK_RESULT_NOTDETECT; > + > + return ret; > + } > + > + if (sync_stat == 6) { > + *lock = CXD2880_TNRDMD_LOCK_RESULT_LOCKED; > + return ret; > + } > + > + ret = > + cxd2880_tnrdmd_dvbt_mon_sync_stat_sub(tnr_dmd, &sync_stat, > + &unlock_detected_sub); > + if (ret) > + return ret; > + > + if (sync_stat == 6) > + *lock = CXD2880_TNRDMD_LOCK_RESULT_LOCKED; > + else if (unlock_detected && unlock_detected_sub) > + *lock = CXD2880_TNRDMD_LOCK_RESULT_UNLOCKED; > + else > + *lock = CXD2880_TNRDMD_LOCK_RESULT_NOTDETECT; > + > + return ret; > +} > + > +int cxd2880_tnrdmd_dvbt_check_ts_lock(struct cxd2880_tnrdmd > + *tnr_dmd, > + enum > + cxd2880_tnrdmd_lock_result > + *lock) > +{ > + int ret = 0; > + > + u8 sync_stat = 0; > + u8 ts_lock = 0; > + u8 unlock_detected = 0; > + u8 unlock_detected_sub = 0; > + > + if ((!tnr_dmd) || (!lock)) > + return -EINVAL; > + > + if (tnr_dmd->diver_mode == CXD2880_TNRDMD_DIVERMODE_SUB) > + return -EINVAL; > + > + if (tnr_dmd->state != CXD2880_TNRDMD_STATE_ACTIVE) > + return -EPERM; > + > + ret = > + cxd2880_tnrdmd_dvbt_mon_sync_stat(tnr_dmd, &sync_stat, &ts_lock, > + &unlock_detected); > + if (ret) > + return ret; > + > + if (tnr_dmd->diver_mode == CXD2880_TNRDMD_DIVERMODE_SINGLE) { > + if (ts_lock) > + *lock = CXD2880_TNRDMD_LOCK_RESULT_LOCKED; > + else if (unlock_detected) > + *lock = CXD2880_TNRDMD_LOCK_RESULT_UNLOCKED; > + else > + *lock = CXD2880_TNRDMD_LOCK_RESULT_NOTDETECT; > + > + return ret; > + } > + > + if (ts_lock) { > + *lock = CXD2880_TNRDMD_LOCK_RESULT_LOCKED; > + return ret; > + } else if (!unlock_detected) { > + *lock = CXD2880_TNRDMD_LOCK_RESULT_NOTDETECT; > + return ret; > + } > + > + ret = > + cxd2880_tnrdmd_dvbt_mon_sync_stat_sub(tnr_dmd, &sync_stat, > + &unlock_detected_sub); > + if (ret) > + return ret; > + > + if (unlock_detected && unlock_detected_sub) > + *lock = CXD2880_TNRDMD_LOCK_RESULT_UNLOCKED; > + else > + *lock = CXD2880_TNRDMD_LOCK_RESULT_NOTDETECT; > + > + return ret; > +} > diff --git a/drivers/media/dvb-frontends/cxd2880/cxd2880_tnrdmd_dvbt.h b/drivers/media/dvb-frontends/cxd2880/cxd2880_tnrdmd_dvbt.h > new file mode 100644 > index 000000000000..f0a36040da3b > --- /dev/null > +++ b/drivers/media/dvb-frontends/cxd2880/cxd2880_tnrdmd_dvbt.h > @@ -0,0 +1,62 @@ > +/* > + * cxd2880_tnrdmd_dvbt.h > + * Sony CXD2880 DVB-T2/T tuner + demodulator driver > + * control interface for DVB-T > + * > + * Copyright (C) 2016, 2017 Sony Semiconductor Solutions Corporation > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms of the GNU General Public License as published by the > + * Free Software Foundation; version 2 of the License. > + * > + * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESS OR IMPLIED > + * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF > + * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN > + * NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, > + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT > + * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF > + * USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON > + * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF > + * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > + * > + * You should have received a copy of the GNU General Public License along > + * with this program; if not, see . > + */ > + > +#ifndef CXD2880_TNRDMD_DVBT_H > +#define CXD2880_TNRDMD_DVBT_H > + > +#include "cxd2880_common.h" > +#include "cxd2880_tnrdmd.h" > + > +struct cxd2880_dvbt_tune_param { > + u32 center_freq_khz; > + enum cxd2880_dtv_bandwidth bandwidth; > + enum cxd2880_dvbt_profile profile; > +}; > + > +int cxd2880_tnrdmd_dvbt_tune1(struct cxd2880_tnrdmd *tnr_dmd, > + struct cxd2880_dvbt_tune_param > + *tune_param); > + > +int cxd2880_tnrdmd_dvbt_tune2(struct cxd2880_tnrdmd *tnr_dmd, > + struct cxd2880_dvbt_tune_param > + *tune_param); > + > +int cxd2880_tnrdmd_dvbt_sleep_setting(struct cxd2880_tnrdmd > + *tnr_dmd); > + > +int cxd2880_tnrdmd_dvbt_check_demod_lock(struct cxd2880_tnrdmd > + *tnr_dmd, > + enum > + cxd2880_tnrdmd_lock_result > + *lock); > + > +int cxd2880_tnrdmd_dvbt_check_ts_lock(struct cxd2880_tnrdmd > + *tnr_dmd, > + enum > + cxd2880_tnrdmd_lock_result > + *lock); > + > +#endif Thanks, Mauro