Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751273AbdH0SBb (ORCPT ); Sun, 27 Aug 2017 14:01:31 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:53602 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751146AbdH0SBa (ORCPT ); Sun, 27 Aug 2017 14:01:30 -0400 Date: Sun, 27 Aug 2017 20:01:36 +0200 From: Greg Kroah-Hartman To: Badhri Jagan Sridharan Cc: Guenter Roeck , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] staging: usb: typec: tcpm set port type callback Message-ID: <20170827180136.GA30883@kroah.com> References: <20170827052324.11854-1-Badhri@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170827052324.11854-1-Badhri@google.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 933 Lines: 25 On Sat, Aug 26, 2017 at 10:23:24PM -0700, Badhri Jagan Sridharan wrote: > The port type callback call enquires the tcpc_dev if > the requested port type is supported. If supported, then > performs a tcpm reset if required after setting the tcpm > internal port_type variable. > > Check against the tcpm port_type instead of checking > against caps.type as port_type reflects the current > configuration. > > Signed-off-by: Badhri Jagan Sridharan > Reviewed-by: Guenter Roeck > --- > drivers/staging/typec/tcpm.c | 52 ++++++++++++++++++++++++++++++++++---------- > 1 file changed, 41 insertions(+), 11 deletions(-) This series is really messed up. I see patches out of 6 and out of 11, and none of it "threaded" so I don't know what is what to apply :( Please resend the whole series, correctly, with Guenter's reviewed-by, so I know what to apply and in what order. thanks, greg k-h