Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751499AbdH0Vpa (ORCPT ); Sun, 27 Aug 2017 17:45:30 -0400 Received: from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:59074 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751368AbdH0Vp3 (ORCPT ); Sun, 27 Aug 2017 17:45:29 -0400 Date: Mon, 28 Aug 2017 00:45:25 +0300 From: Sakari Ailus To: Arvind Yadav Cc: mchehab@kernel.org, gregkh@linuxfoundation.org, hdegoede@redhat.com, alan@linux.intel.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [PATCH] staging: atomisp: constify v4l2_subdev_sensor_ops Message-ID: <20170827214525.qw4oycwsrhvhcwim@valkosipuli.retiisi.org.uk> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1002 Lines: 30 Hi Arvind, On Sun, Aug 27, 2017 at 11:26:39AM +0530, Arvind Yadav wrote: > v4l2_subdev_sensor_ops are not supposed to change at runtime. > v4l2_subdev_sensor_ops are working with const 'sensor' field of > sturct v4l2_subdev_ops. So mark the non-const v4l2_subdev_sensor_ops > structs as const. > > Signed-off-by: Arvind Yadav Thanks for the patch. The change has already been made by this patch: commit 65058214f5c2ebe844916b92d1bece64fd00206e Author: Julia Lawall Date: Tue Aug 8 06:58:29 2017 -0400 media: staging: media: atomisp: constify video_subdev structures These structures are both stored in fields of v4l2_subdev_ops structures, all of which are const, so these structures can be const as well. Done with the help of Coccinelle. Signed-off-by: Julia Lawall Signed-off-by: Mauro Carvalho Chehab -- Sakari Ailus e-mail: sakari.ailus@iki.fi