Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751484AbdH0WD1 convert rfc822-to-8bit (ORCPT ); Sun, 27 Aug 2017 18:03:27 -0400 Received: from esa2.microchip.iphmx.com ([68.232.149.84]:5178 "EHLO esa2.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751368AbdH0WD0 (ORCPT ); Sun, 27 Aug 2017 18:03:26 -0400 X-IronPort-AV: E=Sophos;i="5.41,438,1498546800"; d="scan'208";a="6510341" From: To: , CC: , , , , , Subject: RE: [PATCH] DSA support for Micrel KSZ8895 Thread-Topic: [PATCH] DSA support for Micrel KSZ8895 Thread-Index: AQHTFmUw0U9DBuFKJ0agqkR21h99I6KHec+A//+NV4CAEaPAAIAAKFzp Date: Sun, 27 Aug 2017 22:03:10 +0000 Message-ID: <9235D6609DB808459E95D78E17F2E43D40B0BF9C@CHN-SV-EXMX02.mchp-main.com> References: <20170816075524.GA18532@amd> <20170816140451.GA13006@lunn.ch> <9235D6609DB808459E95D78E17F2E43D40AFF8C1@CHN-SV-EXMX02.mchp-main.com>,<20170827123658.GA727@amd> In-Reply-To: <20170827123658.GA727@amd> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.10.215.90] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 891 Lines: 28 Pavel, Thanks for update and sorry about email format (due to web-access version) I'll do review when getting back to office later this week. - Woojung ________________________________________ From: Pavel Machek [pavel@denx.de] Sent: Sunday, August 27, 2017 8:36 AM To: Woojung Huh - C21699; nathan.leigh.conrad@gmail.com Cc: vivien.didelot@savoirfairelinux.com; f.fainelli@gmail.com; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Tristram.Ha@micrel.com; andrew@lunn.ch; pavel@denx.de Subject: [PATCH] DSA support for Micrel KSZ8895 Hi! So I fought with the driver a bit more, and now I have something that kind-of-works. "great great hack" belows worries me. Yeah, disabled code needs to be removed before merge. No, tag_ksz part probably is not acceptable. Do you see solution better than just copying it into tag_ksz1 file? Any more comments, etc? Help would be welcome.