Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264898AbTGCQQe (ORCPT ); Thu, 3 Jul 2003 12:16:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264925AbTGCQNy (ORCPT ); Thu, 3 Jul 2003 12:13:54 -0400 Received: from hera.cwi.nl ([192.16.191.8]:18160 "EHLO hera.cwi.nl") by vger.kernel.org with ESMTP id S265022AbTGCQLg (ORCPT ); Thu, 3 Jul 2003 12:11:36 -0400 From: Andries.Brouwer@cwi.nl Date: Thu, 3 Jul 2003 18:25:59 +0200 (MEST) Message-Id: To: Andries.Brouwer@cwi.nl, hch@infradead.org Subject: Re: [PATCH] cryptoloop Cc: linux-kernel@vger.kernel.org, torvalds@osdl.org Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 959 Lines: 30 hch: > Some nitpicking: Thanks. In case Linus applied the patch this is unimportant. In case he didnt I'll probably resubmit when 2.5.75 comes out and apply your polishing. > + if (info->lo_encrypt_type == LO_CRYPT_CRYPTOAPI) > > this special-casing sounds like a bad idea. True. But it is only in the compatibility code. Once you rip that out the special casing disappears automatically. It describes current reality. > imho we should rip out the whole concept of transfer functions They are used much more frequently than cryptoapi is. People tell me jari-loop is much faster at present. If this is true, your move would not be very popular. Anyway, I am not doing a redesign. Just a cleanup. Andries - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/