Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751197AbdH1Ecc (ORCPT <rfc822;w@1wt.eu>);
        Mon, 28 Aug 2017 00:32:32 -0400
Received: from mx2.suse.de ([195.135.220.15]:47614 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1750735AbdH1Ecb (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 28 Aug 2017 00:32:31 -0400
Subject: Re: [Xen-devel] [PATCH v8 10/13] x86/xen: Bypass intr mode setup in
 enlighten_pv system
To: Dou Liyang <douly.fnst@cn.fujitsu.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org, tglx@linutronix.de
Cc: indou.takao@jp.fujitsu.com, bhe@redhat.com, izumi.taku@jp.fujitsu.com,
        rjw@rjwysocki.net, bp@alien8.de, hpa@zytor.com,
        xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com,
        mingo@kernel.org
References: <1503890438-27840-1-git-send-email-douly.fnst@cn.fujitsu.com>
 <1503890438-27840-11-git-send-email-douly.fnst@cn.fujitsu.com>
 <4b929f7f-3125-eb1e-86a2-dcaeae727f09@suse.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <2d5f4a0b-31a9-31cc-9403-67a1fe9263d0@suse.com>
Date: Mon, 28 Aug 2017 06:32:28 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <4b929f7f-3125-eb1e-86a2-dcaeae727f09@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1230
Lines: 32

On 28/08/17 06:25, Juergen Gross wrote:
> On 28/08/17 05:20, Dou Liyang wrote:
>> XEN PV overrides smp_prepare_cpus(). xen_pv_smp_prepare_cpus()
>> initializes interrupts in the XEN PV specific way and does not invoke
>> native_smp_prepare_cpus(). As a consequence, x86_init.intr_mode_init() is
>> not invoked either.
>>
>> The invocation of x86_init.intr_mode_init() will be moved from
>> native_smp_prepare_cpus() in a follow up patch to solve <INSERT
>> REASON/PROBLEM>.
> 
> Can you be a little bit more precise here, please? :-)
> 
>> That move would cause the invocation of x86_init.intr_mode_init() for XEN
>> PV platforms. To prevent that, override the default x86_init.
>> intr_mode_init() callback with a noop().
>>
>> [Rewrited by Thomas Gleixner <tglx@linutronix.de>]
>>
>> Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
>> Cc: xen-devel@lists.xenproject.org
>> Cc: boris.ostrovsky@oracle.com
> 
> On which tree does this apply? Would be nice to get a hint against which
> source this can be reviewed.

Aah, just found the rest of the series. In case a single patch of a
series isn't stand alone it would be nice to receive at least the cover
letter of the series in order to know what its all about.


Juergen